[9.0] migrate getDIRACPlatform to DIRACCommon#8295
Merged
fstagni merged 1 commit intoDIRACGrid:integrationfrom Sep 5, 2025
Merged
[9.0] migrate getDIRACPlatform to DIRACCommon#8295fstagni merged 1 commit intoDIRACGrid:integrationfrom
fstagni merged 1 commit intoDIRACGrid:integrationfrom
Conversation
chrisburr
changed the title
chrisburr
force-pushed
the
common-getDIRACPlatform
branch
from
4b3ccb7 to
0ed3dc9
Compare
Migrate getDIRACPlatform function from DIRAC to DIRACCommon to enable shared usage: - Move getDIRACPlatform and _platformSortKey to DIRACCommon/ConfigurationSystem/Client/Helpers/Resources.py - Create stateless DIRACCommon implementation that accepts configuration data as parameters - Update DIRAC module to import from DIRACCommon for backward compatibility - DIRAC wrapper handles gConfig access and passes data to DIRACCommon function - Move and update tests for both DIRACCommon and DIRAC modules - Update DIRACCommon README with comprehensive migration documentation
chrisburr
force-pushed
the
common-getDIRACPlatform
branch
from
0ed3dc9 to
bd09645
Compare
fstagni
reviewed
Sep 5, 2025
Comment on lines
+247
to
+248
| 1. **DIRACCommon tests pass** - `pixi run python -m pytest dirac-common/tests/` | ||
| 2. **DIRAC tests pass** - `pixi run python -m pytest src/DIRAC/` |
Contributor
There was a problem hiding this comment.
We never suggested using pixi for DIRAC (which does not have a pixi,toml), so I would just remove pixi run from these instructions from next PR.
fstagni
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate getDIRACPlatform function from DIRAC to DIRACCommon to enable shared usage:
BEGINRELEASENOTES
*Configuration
CHANGE: Move getDIRACPlatform to DIRACCommon
ENDRELEASENOTES