fix: Use existing DB connection for a few more places in FileManager#8529
Merged
chaen merged 1 commit intoDIRACGrid:integrationfrom May 7, 2026
Merged
fix: Use existing DB connection for a few more places in FileManager#8529chaen merged 1 commit intoDIRACGrid:integrationfrom
chaen merged 1 commit intoDIRACGrid:integrationfrom
Conversation
chaen
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There are a few db._update calls in FileManager that don't use the existing database connection, but probably should. There is a suspicion that the FileInfo one might be behind our occasional "corrupt file" issue where very occasionally an entry is only created in the File table but not FileInfo, but this is too rare for us to directly test.
Regards,
Simon
BEGINRELEASENOTES
*DataManagement
FIX: Use existing connection for all updates in FileManager
ENDRELEASENOTES