[int] Bandit fixups for MySQL#8671
Merged
Merged
Conversation
Contributor
|
Can you have a look at the pre-commit "error"? |
fstagni
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8547.
The queries in the core MySQL module can't be parameterised: There are loads of cases where various SQL functions and syntax are passed through parameters which the parametrisation would break. This patch marks them as safe for bandit (most things are checked with escapeString, etc. already). I've added a few extra checks where it was safe to do so.
It also removes a hack from TransformationDB which no-longer works and replaces it with proper behaviour in the MySQL module (correctly backtick quoting
a.bstyle names if they are provided).BEGINRELEASENOTES
*Core
FIX: Bandit fixups for MySQL
ENDRELEASENOTES