Conversation
|
@fstagni the doc does not build in RTD, in the meantime, these are the page worth mentioning to whoever you think is relevant: |
81cfd3b to
36c857e
Compare
| # "gubbins-core/src/**/*.py", | ||
| "gubbins-db/src/**/*.py", | ||
| "gubbins-logic/src/**/*.py", | ||
| "gubbins-routers/src/**/*.py", |
There was a problem hiding this comment.
Add
| "gubbins-tasks/src/**/*.py", |
| # "$MYPY_CONFIG_FILE_DIR/gubbins-core/src", | ||
| "$MYPY_CONFIG_FILE_DIR/gubbins-db/src", | ||
| "$MYPY_CONFIG_FILE_DIR/gubbins-logic/src", | ||
| "$MYPY_CONFIG_FILE_DIR/gubbins-routers/src", |
There was a problem hiding this comment.
Add
| "$MYPY_CONFIG_FILE_DIR/gubbins-tasks/src", |
| importlib-metadata = "<8.8.0" | ||
| # Dependencies for run_local.sh | ||
| redis-server = "*" | ||
| seaweedfs = "*" |
There was a problem hiding this comment.
This is not part of this PR, right? Maybe refrain from adding it right now (it's also somewhere else in this PR)
There was a problem hiding this comment.
I actually see it added in several places. Can you clarify?
There was a problem hiding this comment.
Like it says in the comment: # Dependencies for run_local.sh
See https://diracx--842.org.readthedocs.build/en/842/dev/tutorials/advanced-tutorial/running-locally/ for more details.
| _SandboxStoreSettings, Depends(_SandboxStoreSettings.create) | ||
| ] | ||
| # Re-export everything from the canonical location | ||
| from diracx.tasks.plumbing.depends import * # noqa: F401, F403 |
There was a problem hiding this comment.
Do we want diracx-routers to depend on diracx-tasks?
I would have naively imagined:
diracx-logic
|
-> diracx-tasks
|
-> diracx-routers
There was a problem hiding this comment.
Note: there is a mermaid diagram in the documentation that would need to be adapted:
diracx/docs/dev/explanations/components/index.md
Lines 33 to 74 in 7cae3ca
There was a problem hiding this comment.
Co-authored-by: Christophe Haen <christophe.haen@cern.ch>
No description provided.