Skip to content

Ajoute une liste éditable des élements transverse de l'audit#964

Merged
hissalht merged 8 commits intomainfrom
780-rappel-des-éléments-audités-dans-longlet-transverse
Mar 12, 2025

Hidden character warning

The head ref may contain hidden characters: "780-rappel-des-\u00e9l\u00e9ments-audit\u00e9s-dans-longlet-transverse"
Merged

Ajoute une liste éditable des élements transverse de l'audit#964
hissalht merged 8 commits intomainfrom
780-rappel-des-éléments-audités-dans-longlet-transverse

Conversation

@hissalht
Copy link
Copy Markdown
Collaborator

@hissalht hissalht commented Feb 20, 2025

closes #780

Avant de merger la pull request, s’assurer que :

  • Les checks GitHub passent (lint...).
  • Les tests Cypress ont été lancés en local (dans le cas d’une correction de bug ou d’une nouvelle fonctionnalité).

@hissalht hissalht linked an issue Feb 20, 2025 that may be closed by this pull request
Rappel des éléments audités dans l'onglet transverse #780
Closed
@hissalht hissalht temporarily deployed to ara-780-rappel-des-elem-izword February 20, 2025 14:17 Inactive
@hissalht hissalht temporarily deployed to ara-780-rappel-des-elem-izword February 20, 2025 15:07 Inactive
@hissalht hissalht force-pushed the 780-rappel-des-éléments-audités-dans-longlet-transverse branch from 9060c88 to a2ca35c Compare February 20, 2025 15:08
@hissalht hissalht marked this pull request as ready for review February 20, 2025 15:08
@hissalht hissalht requested review from bellangerq and yaaax February 20, 2025 15:08
@hissalht hissalht temporarily deployed to ara-780-rappel-des-elem-izword February 20, 2025 15:08 Inactive
@benoitdequick
Copy link
Copy Markdown
Contributor

benoitdequick commented Feb 25, 2025

Faudrait aussi penser à l'affichage de ces informations côté rapport dans les onglets détail des nc et points d'amélioration

@AdrienMuzyczka
Copy link
Copy Markdown
Collaborator

AdrienMuzyczka commented Feb 25, 2025 •
edited
Loading

Autres retours :

  • Passer en taille MD les boutons “Enregistrer” et “Annuler”
  • Ajouter un espace de 16 px entre ces 2 boutons (utiliser un “groupe de boutons” ?)
  • Si l’usager clique sur “Enregistrer” et qu’une saisie est présente, créer un tag

Affichage tags dans le rapport : https://www.figma.com/design/lbnXmYmTsTgkWvgzdR6W1c/Ara_V0.10_B%C3%AAta?node-id=7197-567337&t=K1wnQOjLLCFGRPO0-1

@hissalht hissalht temporarily deployed to ara-780-rappel-des-elem-izword February 26, 2025 16:32 Inactive
bellangerq
bellangerq requested changes Feb 27, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread confiture-web-app/src/components/audit/TransverseElementsList.vue Outdated
Comment thread confiture-web-app/src/components/audit/TransverseElementsList.vue Outdated
Comment thread confiture-web-app/src/components/audit/TransverseElementsList.vue
Comment thread confiture-web-app/src/components/audit/TransverseElementsList.vue
Comment thread confiture-web-app/src/components/ui/DsfrField.vue
@benoitdequick
Copy link
Copy Markdown
Contributor

benoitdequick commented Feb 27, 2025

Il faudrait ajouter un <span sr-only> l'élement transverse au bouton Ajouter. (comme pour le bouton modifier)

@hissalht hissalht temporarily deployed to ara-780-rappel-des-elem-izword February 27, 2025 15:31 Inactive
@hissalht hissalht had a problem deploying to ara-780-rappel-des-elem-izword March 12, 2025 14:48 Failure
@hissalht hissalht force-pushed the 780-rappel-des-éléments-audités-dans-longlet-transverse branch from beb1501 to 2b01794 Compare March 12, 2025 15:06
@hissalht hissalht temporarily deployed to ara-780-rappel-des-elem-izword March 12, 2025 15:07 Inactive
@hissalht hissalht temporarily deployed to ara-780-rappel-des-elem-izword March 12, 2025 15:13 Inactive
@hissalht hissalht merged commit 30829a5 into main Mar 12, 2025
@hissalht hissalht deleted the 780-rappel-des-éléments-audités-dans-longlet-transverse branch March 12, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellangerq bellangerq bellangerq requested changes

@yaaax yaaax Awaiting requested review from yaaax

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rappel des éléments audités dans l'onglet transverse

4 participants

@hissalht @benoitdequick @AdrienMuzyczka @bellangerq