Added eightfold.

[rl2939]

Added the eightfold modules.

[rl2939]

How do I fix the build error that the checks are complaining about (below)? It builds without error on my machine.

eightfold/src/SDOrcasHeartV2.cpp:320:33: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                 ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
eightfold/src/SDOrcasHeartV2.cpp:320:44: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                            ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
eightfold/src/SDOrcasHeartV2.cpp:320:63: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                                               ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
eightfold/src/SDOrcasHeartV2.cpp:320:81: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                                                                 ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
make[1]: *** [Makefile:2365: ../build/plugins/eightfold/src/SDOrcasHeartV2.cpp.o] Error 1

[falkTX]

maybe this needs c++17 too?

[rl2939]

maybe this needs c++17 too?

When I built it, it used c++17. So maybe?

Is there a way to make it so that only certain modules use c++17?

[dromer]

You will have to adjust the specific build flags in the Makefile.

See how other modules do this, like Befaco.

[cosinekitty]

If it helps, I use C++17 in Sapphire. It's very simple. Take a look at the Makefile, specifically line 23 and line 29.

[rl2939]

You will have to adjust the specific build flags in the Makefile.

See how other modules do this, like Befaco.

Take a look at the Makefile, specifically line 23 and line 29.

@dromer @cosinekitty , thanks for your help. I was able to get around the C++ compiler errors, but now I am getting unable to access 'https://gitlab.xiph.org/xiph/speexdsp.git/': The requested URL returned error: 502 in the actions settings. Is there a rate limit in xiph.org, or is there something else going on?

[falkTX]

the licenses file is missing info regarding artwork usage

[rl2939]

the licenses file is missing info regarding artwork usage

I set up an issue here: scanner-darkly/eightfold#2.

[falkTX]

typically that means the artwork uses the same license as the code and the overall project

[rl2939]

From this comment, I added the new information about the artwork to LICENSES.md. Was this what you meant? I could not find an artwork license, similar to other GPL-3.0-or-later plugins like the MUS-X and Myth collections.

[dromer]

Correct.