Skip to content

fix(route/2048): update target URL to ensure proper redirection#21064

Merged
TonyRL merged 1 commit intoDIYgod:masterfrom
TonyRL:fix/2048
Feb 4, 2026
Merged

fix(route/2048): update target URL to ensure proper redirection#21064
TonyRL merged 1 commit intoDIYgod:masterfrom
TonyRL:fix/2048

Conversation

@TonyRL
Copy link
Collaborator

@TonyRL TonyRL commented Feb 4, 2026

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/2048/2

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

Copilot AI review requested due to automatic review settings February 4, 2026 10:03
@github-actions github-actions bot added the route label Feb 4, 2026
Copilot AI reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the URL handling in the 2048 route to properly resolve relative URLs by using the new URL() constructor with a base URL parameter. The change addresses an issue where the targetUrl extracted from an onclick attribute might be relative and needs to be resolved against the base URL https://2048.info.

Changes:

  • Modified line 75 to use new URL(targetUrl, 'https://2048.info').href instead of directly returning targetUrl

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/routes/2048/index.tsx
const targetUrl = onclickValue?.match(/window\.open\('([^']+)'/)?.[1];

return { url: targetUrl };
return { url: new URL(targetUrl, 'https://2048.info').href };
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The targetUrl variable can be undefined if the regex match fails (line 73 uses optional chaining). Passing undefined to the URL constructor will throw a TypeError. Consider adding a null/undefined check before constructing the URL, or providing a fallback value.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Successfully generated as following:

http://localhost:1200/2048/2 - Success ✔️ 
<?xml version="1.0" encoding="UTF-8"?>
<rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
  <channel>
    <title>新片速递 - 2048核基地</title>
    <link>https://qav6.php7plus.com/thread.php?fid-2.html</link>
    <atom:link href="http://localhost:1200/2048/2" rel="self" type="application/rss+xml"></atom:link>
    <description>新片速递 - 2048核基地 - Powered by RSSHub</description>
    <generator>RSSHub</generator>
    <webMaster>contact@rsshub.app (RSSHub)</webMaster>
    <language>en</language>
    <lastBuildDate>Wed, 04 Feb 2026 10:08:12 GMT</lastBuildDate>
    <ttl>5</ttl>
    <item>
      <title>在线影片超百万 原档下载 同步更新 高速播放 合集播放</title>
      <description>&lt;a href=&quot;https://qav6.php7plus.com/yy.php&quot; target=&quot;_blank&quot; style=&quot;outline: none; text-decoration-line: none; color: rgb(0, 112, 175); font-family: Arial; font-size: 17px; background-color: rgb(245, 250, 254);&quot;&gt;☛ 在线看片~&lt;/a&gt;&lt;div&gt;&lt;br&gt;&lt;a href=&quot;https://qav6.php7plus.com/yy.php&quot; target=&quot;_blank&quot; style=&quot;outline: none; text-decoration-line: none; color: rgb(0, 112, 175); font-family: Arial; font-size: 17px; background-color: rgb(245, 250, 254);&quot;&gt;☛ 在线看片~&lt;/a&gt;&lt;/div&gt;&lt;div&gt;&lt;br&gt;&lt;a href=&quot;https://qav6.php7plus.com/yy.php&quot; target=&quot;_blank&quot; style=&quot;outline: none; text-decoration-line: none; color: rgb(0, 112, 175); font-family: Arial; font-size: 17px; background-color: rgb(245, 250, 254);&quot;&gt;☛ 在线看片~&lt;/a&gt;&lt;/div&gt;&lt;!--&lt;div style=&quot;margin: 10px 0px -20px 0px;color:#d4237a;border:1px dashed;display:flex;width: fit-content;&quot; class=&quot;blockquote&quot;&gt;--&gt;
        &lt;!-- &lt;div&gt;&lt;img style=&quot;width:20px;&quot; src=&quot;images/notice11.png&quot; border=&quot;0&quot;&gt;&lt;/div&gt;--&gt;
        &lt;!-- &lt;b&gt;购买本帖会留有购买记录，为保证资源时效，请勿搬运，发现一律永久禁言，想挑衅的請略過此警告！&lt;/b&gt;--&gt;
        &lt;!-- &lt;div&gt;&lt;img style=&quot;width:20px;&quot; src=&quot;images/notice11.png&quot; border=&quot;0&quot;&gt;&lt;/div&gt;--&gt;
        &lt;!-- &lt;/div&gt;--&gt;
      </description>
      <link>https://qav6.php7plus.com/read.php?tid=14022439</link>
      <guid isPermaLink="false">https://hjd2048.com/2048/read.php?tid=14022439</guid>
      <pubDate>Mon, 06 May 2024 13:21:00 GMT</pubDate>
      <author>匿名</author>
    </item>
    <item>
      <title>我为人人回家指南&amp;pc安卓地址发布器下载</title>
      <description>&lt;font size=&quot;3&quot;&gt;&lt;b&gt;想要永远不丢失本站,至少下载一个发布器作为主体，苹果用户请收藏右上角的地址发布页，建议两个一起收藏~&lt;br&gt;&lt;br&gt;1.现PC版发布器经过改良更新，可百分百获取最新地址！&lt;/b&gt;&lt;/font&gt;&lt;br&gt;&lt;font size=&quot;3&quot;&gt;&lt;b&gt;运行前请关闭流氓软件360~&lt;/b&gt;&lt;/font&gt;&lt;br&gt;&lt;font size=&quot;3&quot;&gt;&lt;b&gt;解压密码：2048&lt;/b&gt;&lt;/font&gt;&lt;br&gt;&lt;font size=&quot;3&quot;&gt;&lt;b&gt;&lt;br&gt;&lt;/b&gt;&lt;/font&gt;&lt;br&gt;&lt;font size=&quot;3&quot;&gt;&lt;b&gt;&lt;font color=&quot;#ff0000&quot;&gt;牢记2048永久域名 2048.cc 或 hjd2048.com(已墙)&lt;/font&gt;&lt;br&gt;&lt;/b&gt;&lt;/font&gt;&lt;br&gt;&lt;a href=&quot;https://qav6.php7plus.com/2048.zip&quot;&gt;&lt;b&gt;&lt;font size=&quot;5&quot;&gt;点此高速下载电脑版发布器&lt;/font&gt;&lt;/b&gt;&lt;/a&gt;&amp;nbsp;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;font size=&quot;5&quot;&gt;请各位发帖员统一更新文宣 谢谢！&lt;/font&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;!--&lt;div style=&quot;margin: 10px 0px -20px 0px;color:#d4237a;border:1px dashed;display:flex;width: fit-content;&quot; class=&quot;blockquote&quot;&gt;--&gt;
        &lt;!-- &lt;div&gt;&lt;img style=&quot;width:20px;&quot; src=&quot;images/notice11.png&quot; border=&quot;0&quot;&gt;&lt;/div&gt;--&gt;
        &lt;!-- &lt;b&gt;购买本帖会留有购买记录，为保证资源时效，请勿搬运，发现一律永久禁言，想挑衅的請略過此警告！&lt;/b&gt;--&gt;
        &lt;!-- &lt;div&gt;&lt;img style=&quot;width:20px;&quot; src=&quot;images/notice11.png&quot; border=&quot;0&quot;&gt;&lt;/div&gt;--&gt;
        &lt;!-- &lt;/div&gt;--&gt;
      </description>
      <link>https://qav6.php7plus.com/read.php?tid=13283237</link>
      <guid isPermaLink="false">https://hjd2048.com/2048/read.php?tid=13283237</guid>
      <pubDate>Thu, 07 Mar 2024 19:49:00 GMT</pubDate>
      <author>admin</author>
    </item>
    <item>
      <title>■■■ 來訪者必看的內容 - 使你更快速上手 &lt;隨時更新&gt; ■■■</title>
      <description>&lt;div class=&quot;pw_notice_bar&quot; style=&quot;margin:10px 0 14px;padding:12px 16px;background:#efefeb;border:2px dashed #e6a3a3;border-radius:8px;font-size:14px;color:#333;line-height:1.9;box-sizing:border-box;&quot;&gt;&lt;span style=&quot;&amp;quot;font-weight:700;color:#c0392b;&amp;quot;&quot;&gt;提示：&lt;/span&gt; 禁止一号多次回复灌水，如发现单一账号在同一帖内连续灌水回复，&lt;strong style=&quot;&amp;quot;color:#c0392b;&amp;quot;&quot;&gt;杀无赦&lt;/strong&gt;。&lt;br&gt;&lt;span style=&quot;&amp;quot;font-weight:700;color:#555;&amp;quot;&quot;&gt;注意：&lt;/span&gt; 请尊重分享者的帖子内容，有金币的请多多打赏分享者！&lt;/div&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font size=&quot;4&quot;&gt;警告︰此社區只適合十八歲或以上人士觀看。內容可能令人反感；不可將此論壇的內容派發、傳閱、出售、出租、交給或借予年齡未滿18歲的人士或將本網站內容向該人士出示、&lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;br&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font size=&quot;4&quot;&gt;播放或放映。&lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;br&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font size=&quot;4&quot;&gt;&lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font size=&quot;4&quot;&gt;LEGAL DISCLAIMER WARNING: THIS FORUM CONTAINS MATERIAL WHICH MAY OFFEND AND MAY NOT BE DISTRIBUTED, CIRCULATED, SOLD, HIRED, GIVEN, &lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;br&gt;&lt;br&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font size=&quot;4&quot;&gt;&lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font size=&quot;4&quot;&gt;LENT,SHOWN, PLAYED OR PROJECTED TO A PERSON UNDER THE AGE OF 18 YEARS. &lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;br&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font size=&quot;4&quot;&gt;&lt;br&gt;&lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;font size=&quot;5&quot;&gt;&lt;span style=&quot;color:red &quot;&gt;&lt;font face=&quot;黑体 &quot;&gt;&lt;b&gt;&lt;font size=&quot;3&quot;&gt;&lt;span style=&quot;color:deeppink &quot;&gt;&lt;font size=&quot;4&quot;&gt;前言&lt;/font&gt;&lt;/span&gt;&lt;font size=&quot;4&quot;&gt;&lt;br&gt;&lt;br&gt;歡迎來到2048核基地, 您在本論壇可以言論自由, 但是不能觸及美國法律, 違者屏蔽IP處理&lt;br&gt;&lt;br&gt;在本論壇註冊後, 您將享有發帖以及回帖的權限, 當您有資源打算分享時, 我們十分歡迎您的發佈! 但嚴禁發佈幼交和獸交的片子&lt;br&gt;&lt;br&gt;&lt;span style=&quot;color:deeppink &quot;&gt;升級&lt;br&gt;&lt;br&gt;&lt;/span&gt;升級點數 = 威望*1 + 貢獻值*0.02&lt;br&gt;&lt;br&gt;威望: 發佈一個帖子威望+1, 回復10個帖子威望+1&lt;br&gt;&lt;br&gt;貢獻值: 請查看個人&amp;lt;控制面板&amp;gt;&amp;lt;查看個人資料&amp;gt; &lt;br&gt;&lt;br&gt;由上述計算公式看出, 要想儘快提升等級, 發佈主題是最快速的, 等級高了權限和地位也就高了&lt;br&gt;&lt;br&gt;&lt;span style=&quot;color:deeppink &quot;&gt;發佈資源&lt;br&gt;&lt;br&gt;&lt;/span&gt;圖片上傳空間:&lt;br&gt;&lt;br&gt;&lt;a href=&quot;https://img.y7mn.com/&quot; target=&quot;_blank&quot;&gt;https://img.y7mn.com&lt;/a&gt;&lt;br&gt;&lt;br&gt;&lt;br&gt;種子上傳空間:&lt;br&gt;&lt;br&gt;&lt;br&gt;&lt;a href=&quot;https://data.elsbbus.com/&quot; target=&quot;_blank&quot;&gt;https://data.elsbbus.com&lt;/a&gt;&lt;br&gt;&lt;br&gt;&lt;span style=&quot;color:deeppink &quot;&gt;其他&lt;/span&gt;&lt;br&gt;&lt;br&gt;1）如果您一時無法訪問社區, 請不要著急, 也許服務器上出現了技術故障, 一會就會自動恢復. 當確實無法訪問了, 請在地址發佈器或文宣內查看最&lt;br&gt;&lt;br&gt;新地址或收藏最新地址發佈頁&lt;br&gt;&lt;br&gt;2）站務聯繫：hjd2048#gmail.com&amp;nbsp;&amp;nbsp;&amp;nbsp;&amp;nbsp;把#改成@&amp;nbsp;&amp;nbsp;Replace # to @&lt;br&gt;&lt;br&gt;3）2048核基地從未向用戶收取任何費用用於激活賬號、瀏覽網站，均是完全免費使用。如果您在瀏覽社區時要求付費，則是上了仿冒的2048，請您立刻停止瀏覽。&lt;br&gt;&lt;br&gt;&lt;span style=&quot;color:deeppink &quot;&gt;致中國大陸用戶&lt;/span&gt;&lt;br&gt;&lt;br&gt;2048上發布的資源與信息, 與中國大陸相關法律抵觸, 在您瀏覽本網站時, 請自覺遵守當地法律&lt;/font&gt;&lt;/font&gt;&lt;/b&gt;&lt;/font&gt;&lt;/span&gt;&lt;/font&gt;&lt;!--&lt;div style=&quot;margin: 10px 0px -20px 0px;color:#d4237a;border:1px dashed;display:flex;width: fit-content;&quot; class=&quot;blockquote&quot;&gt;--&gt;
        &lt;!-- &lt;div&gt;&lt;img style=&quot;width:20px;&quot; src=&quot;images/notice11.png&quot; border=&quot;0&quot;&gt;&lt;/div&gt;--&gt;
        &lt;!-- &lt;b&gt;购买本帖会留有购买记录，为保证资源时效，请勿搬运，发现一律永久禁言，想挑衅的請略過此警告！&lt;/b&gt;--&gt;
        &lt;!-- &lt;div&gt;&lt;img style=&quot;width:20px;&quot; src=&quot;images/notice11.png&quot; border=&quot;0&quot;&gt;&lt;/div&gt;--&gt;
        &lt;!-- &lt;/div&gt;--&gt;
      </description>
      <link>https://qav6.php7plus.com/read.php?tid=4</link>
      <guid isPermaLink="false">https://hjd2048.com/2048/read.php?tid=4</guid>
      <pubDate>Tue, 20 Mar 2018 15:00:00 GMT</pubDate>
      <author>系統消息</author>
    </item>
  </channel>
</rss>

@TonyRL TonyRL merged commit 5c416b8 into DIYgod:master Feb 4, 2026
37 of 38 checks passed
@TonyRL TonyRL deleted the fix/2048 branch February 4, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

auto: ready to review route

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TonyRL