Base CVector on RwV3d#295
Conversation
|
Not sure this is the best of the approaches, CVector is shared across other games, and it's not how any of the trilogy does it. |
|
Unification was your idea to start with and it makes sense. There is no really need to hook game code just to sum 6 floats. |
|
Yes, shared is alright, I meanly meant using RwV3d as parent. |
|
https://github.com/gta-reversed/gta-reversed/blob/master/source/game_sa/Core/Vector.h#L16 Problem with original function names is they were not consistent across platforms. |
|
I guess so, then let's merge and hope for the best |
Instead of having two structs with same members
CVectorin now based onRwV3d(reversed project does it too).Added conversion operators, so both types can be used interchangeable.
Got rid of manual conversion methods.