Improvement: redesigns vtk compilation#1481
Merged
Conversation
Davknapp
reviewed
Mar 17, 2025
Davknapp
requested changes
Mar 24, 2025
Collaborator
|
Can you indent
|
Davknapp
reviewed
Mar 27, 2025
Collaborator
Davknapp
left a comment
There was a problem hiding this comment.
This will be your first contribution to t8code! Congratulations for that. To successfully contribute, can you please add your author file to doc/ . Please name it similar to the others and add a BSD License-statement there. Thank you.
…into redesign-vtk-compilation
Davknapp
requested changes
Apr 11, 2025
Davknapp
reviewed
Apr 14, 2025
Collaborator
Davknapp
left a comment
There was a problem hiding this comment.
Can you address my comment about the documentation? Then we are probably ready to merge.
Davknapp
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1537
Describe your changes here:
This PR changes the way vtk compilation is done. Before we used macros to check whether VTK is linked or not and depending on that, some fuctions were defined and some were not. This PR aims to seperate these complications ultimately improving readabilty.
NOTE: not all files have been converted yet. t8_vtk_writer.cxx, t8_vtk_writer.hxx and t8_vtk_writer.h have been omitted to avoid this PR being too large
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.Tag Label
License
doc/(or already has one).