Bugfix: T8ddy learns how to use a page to iterate over all items in a project#1565
Merged
lenaploetzke merged 3 commits intomainfrom Apr 9, 2025
Merged
Bugfix: T8ddy learns how to use a page to iterate over all items in a project#1565lenaploetzke merged 3 commits intomainfrom
lenaploetzke merged 3 commits intomainfrom
Conversation
lenaploetzke
reviewed
Apr 9, 2025
Collaborator
lenaploetzke
left a comment
There was a problem hiding this comment.
Nice work! just a two comments for a nicer output ;)
Collaborator
Author
Thanks for the nice review! Applied your suggestions and hope you are happy now. |
lenaploetzke
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1564
Use page cursors to get around the item limit set by gh.
We allow a maximum of 100 iterations to prevent an endless loop if an error occurs.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).