Skip to content

Bugfix: T8ddy learns how to use a page to iterate over all items in a project#1565

Merged
lenaploetzke merged 3 commits intomainfrom
t8ddy_learns_how_to_use_a_page
Apr 9, 2025
Merged

Bugfix: T8ddy learns how to use a page to iterate over all items in a project#1565
lenaploetzke merged 3 commits intomainfrom
t8ddy_learns_how_to_use_a_page

Conversation

@Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Apr 8, 2025

Closes #1564
Use page cursors to get around the item limit set by gh.
We allow a maximum of 100 iterations to prevent an endless loop if an error occurs.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@Davknapp Davknapp requested a review from lenaploetzke April 8, 2025 14:14
@Davknapp Davknapp requested review from lenaploetzke and removed request for lenaploetzke April 8, 2025 14:15
@Davknapp Davknapp changed the title T8ddy learns how to use a page to iterate over all items in a project Bugfix: T8ddy learns how to use a page to iterate over all items in a project Apr 8, 2025
Copy link
Collaborator

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! just a two comments for a nicer output ;)

@lenaploetzke lenaploetzke assigned Davknapp and unassigned lenaploetzke Apr 9, 2025
@Davknapp
Copy link
Collaborator Author

Davknapp commented Apr 9, 2025

Nice work! just a two comments for a nicer output ;)

Thanks for the nice review! Applied your suggestions and hope you are happy now.

@Davknapp Davknapp requested a review from lenaploetzke April 9, 2025 10:55
@Davknapp Davknapp assigned lenaploetzke and unassigned Davknapp Apr 9, 2025
@lenaploetzke lenaploetzke added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit d4e3b9b Apr 9, 2025
35 checks passed
@lenaploetzke lenaploetzke deleted the t8ddy_learns_how_to_use_a_page branch April 9, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t8ddy should learn to read books

2 participants