Skip to content

Bugfix: is_refinable usage#1598

Merged
holke merged 2 commits intomainfrom
fix-is_refinable_check
May 9, 2025
Merged

Bugfix: is_refinable usage#1598
holke merged 2 commits intomainfrom
fix-is_refinable_check

Conversation

@sandro-elsweijer
Copy link
Member

@sandro-elsweijer sandro-elsweijer commented Apr 17, 2025

Closes #1599

Describe your changes here:
The element_is_refinable usage was wrong.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer added Bug For a bug in the Code shouldn't take long Can be resolved in under 30 mins priority:medium Should be solved within half a year workload:low Would take half a day or less labels Apr 17, 2025
@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review April 18, 2025 09:01
@Davknapp Davknapp requested a review from holke April 28, 2025 13:05
Copy link
Collaborator

@holke holke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

But the adapt call in the recursive adaptation must also be changed.

if (refine == 1) {

@holke holke assigned sandro-elsweijer and unassigned holke May 2, 2025
@sandro-elsweijer
Copy link
Member Author

Looks good.

But the adapt call in the recursive adaptation must also be changed.

if (refine == 1) {

Nice catch! Done

@holke holke added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 7c04801 May 9, 2025
35 checks passed
@holke holke deleted the fix-is_refinable_check branch May 9, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug For a bug in the Code priority:medium Should be solved within half a year shouldn't take long Can be resolved in under 30 mins workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugfix: is_refinable usage

2 participants