Improvement: Renamed forest functions to explicitly say leaf elements#1606
Merged
Improvement: Renamed forest functions to explicitly say leaf elements#1606
Conversation
Collaborator
|
does it close issue 1508? If so, can please mark it with one of the keywords and delete the automatically opened issue 1607 |
15 tasks
Collaborator
Author
Thanks for pointing that out, I already fixed this typo. This PR does not close #1508, but only the subissue #1604. Once both #1604 and #1605 are closed, I will make sure to close #1508 |
ole-alb
previously approved these changes
May 20, 2025
ole-alb
reviewed
May 20, 2025
Contributor
ole-alb
left a comment
There was a problem hiding this comment.
Can you please add theses changes in the NEWS.md?
ole-alb
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1604
Describe your changes here:
Based on the discussion we had regarding issue #1508 , this PR renames some forest-related functions: Their names now expicitly use "leaf_elements" whenever suitable.
Note the related but separate PR renaming some member variables: #1608
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).