Improvement: Better handling of hashes and errors in t8_geometry [2/2]#1656
Merged
sandro-elsweijer merged 23 commits intomainfrom Jun 16, 2025
Merged
Improvement: Better handling of hashes and errors in t8_geometry [2/2]#1656sandro-elsweijer merged 23 commits intomainfrom
sandro-elsweijer merged 23 commits intomainfrom
Conversation
37fa64b to
3b426ad
Compare
16 tasks
Davknapp
reviewed
May 20, 2025
Davknapp
reviewed
May 20, 2025
sandro-elsweijer
requested changes
May 20, 2025
…' into feature-geometry_improved_hashes
sandro-elsweijer
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1657
Requires merging of #1662 first.
Describe your changes here:
I stumbled on this while testing something else and noticed that if a tree has no geometry, but we query for it (for example when trying to print VTK), we run into a segfault.
While working on this i noticed that the handling of hash values of geometries should be improved.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).