Skip to content

Improvement: Runtime of nca test#1678

Merged
ole-alb merged 3 commits intomainfrom
improve_nca_test
May 28, 2025
Merged

Improvement: Runtime of nca test#1678
ole-alb merged 3 commits intomainfrom
improve_nca_test

Conversation

@Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented May 23, 2025

Describe your changes here:
Closes #1647
changed a little the recursion depth.
The most time was spend on the last test in the testsuite, because it always tested up to maxlvl. Reduced it down to maxlvl/2 for test levels other than 0.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@spenke91 spenke91 requested a review from ole-alb May 26, 2025 13:37
Copy link
Contributor

@ole-alb ole-alb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you changed the name of ´recursion_depthin tostart_level` in the last test, can you please also change it in the comment in line 259? I wasn't able to make suggested change.

@ole-alb ole-alb assigned Davknapp and unassigned ole-alb May 27, 2025
@ole-alb ole-alb added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 865f311 May 28, 2025
40 of 41 checks passed
@ole-alb ole-alb deleted the improve_nca_test branch May 28, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce test_level for the nca and investigate for further speed-up

2 participants