Skip to content

Improvement: Speed up element is leaf test#1679

Merged
ole-alb merged 2 commits intomainfrom
speed_up_element_is_leaf_test
May 27, 2025
Merged

Improvement: Speed up element is leaf test#1679
ole-alb merged 2 commits intomainfrom
speed_up_element_is_leaf_test

Conversation

@Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented May 23, 2025

Describe your changes here:
Closes #1646

Adapts the original test to only be parametrized over all schemes, eclasses and a level. The functionality is tree specific and therefore does not need to run over all cmeshes in our testsuite.

Adds a test for a all scheme collections to test if the right function is called in a hybrid forest.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@Davknapp Davknapp changed the title Speed up element is leaf test Improvement: Speed up element is leaf test May 23, 2025
@spenke91 spenke91 requested a review from ole-alb May 26, 2025 13:37
@ole-alb ole-alb added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit 30c190e May 27, 2025
48 checks passed
@ole-alb ole-alb deleted the speed_up_element_is_leaf_test branch May 27, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make t8_gtest_element_is_leaf_serial a tree-local test

2 participants