Skip to content

Improvement: Remove a magic number#1779

Merged
Davknapp merged 1 commit intomainfrom
remove_magic_number
Jul 21, 2025
Merged

Improvement: Remove a magic number#1779
Davknapp merged 1 commit intomainfrom
remove_magic_number

Conversation

@sandro-elsweijer
Copy link
Member

@sandro-elsweijer sandro-elsweijer commented Jul 21, 2025

Closes #1780

Describe your changes here:
Removes a magic number in a cmesh attribute and replaces it with the correct macro.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer added shouldn't take long Can be resolved in under 30 mins priority:low Should be solved eventually workload:low Would take half a day or less labels Jul 21, 2025
@sandro-elsweijer sandro-elsweijer changed the title rImprovement: Remove a magic number Improvement: Remove a magic number Jul 21, 2025
@Davknapp Davknapp enabled auto-merge July 21, 2025 12:16
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (e73f517) to head (cec7af8).
Report is 194 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1779   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files          99       99           
  Lines       18703    18703           
=======================================
  Hits        13852    13852           
  Misses       4851     4851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davknapp Davknapp added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit e7ec178 Jul 21, 2025
38 checks passed
@Davknapp Davknapp deleted the remove_magic_number branch July 21, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:low Should be solved eventually shouldn't take long Can be resolved in under 30 mins workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rImprovement: Remove a magic number

2 participants