Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1794 +/- ##
==========================================
- Coverage 74.51% 74.39% -0.13%
==========================================
Files 100 101 +1
Lines 19104 19178 +74
==========================================
+ Hits 14236 14268 +32
- Misses 4868 4910 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Niklas and I discussed this topic and it seems there was a misunderstanding about this problem. Niklas proposed solution does not fix the problem. But I tried to use a FindMPI script which can control the MPI CXX interface via a variable, but this also did not work. |
Davknapp
requested changes
Aug 4, 2025
Davknapp
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1795
Describe your changes here:
I have the problem, that I have to build t8code with OpenMPI .
This works as long as I link to a self-build SC, because the arising warnings are within SC and Werror of t8code does not trigger.
But when I try to build t8code with the shipped SC, the warnings are part of t8code and Werror will kick in.
Therefore, i implemented a check which determines if OpenMPI was used and then suppresses that the warning for SC (not for t8code) is treated as an error.
The code builds an example program which checks if this macro was defined.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).