Skip to content

Fix: OpenMPI linkage#1794

Merged
Davknapp merged 3 commits intomainfrom
fix-openmpi_linkage
Aug 7, 2025
Merged

Fix: OpenMPI linkage#1794
Davknapp merged 3 commits intomainfrom
fix-openmpi_linkage

Conversation

@sandro-elsweijer
Copy link
Member

@sandro-elsweijer sandro-elsweijer commented Jul 23, 2025

Closes #1795

Describe your changes here:
I have the problem, that I have to build t8code with OpenMPI .
This works as long as I link to a self-build SC, because the arising warnings are within SC and Werror of t8code does not trigger.
But when I try to build t8code with the shipped SC, the warnings are part of t8code and Werror will kick in.
Therefore, i implemented a check which determines if OpenMPI was used and then suppresses that the warning for SC (not for t8code) is treated as an error.
The code builds an example program which checks if this macro was defined.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer added shouldn't take long Can be resolved in under 30 mins priority:medium Should be solved within half a year workload:low Would take half a day or less labels Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.39%. Comparing base (9e88865) to head (d8aa6bb).
⚠️ Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
- Coverage   74.51%   74.39%   -0.13%     
==========================================
  Files         100      101       +1     
  Lines       19104    19178      +74     
==========================================
+ Hits        14236    14268      +32     
- Misses       4868     4910      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandro-elsweijer sandro-elsweijer added the CMake Is about the CMake build system label Jul 24, 2025
@Davknapp Davknapp self-assigned this Jul 28, 2025
@Davknapp Davknapp self-requested a review July 28, 2025 13:16
@Davknapp Davknapp assigned Niklas997 and unassigned Davknapp Jul 28, 2025
@Davknapp Davknapp requested review from Niklas997 and removed request for Davknapp July 28, 2025 13:17
@sandro-elsweijer
Copy link
Member Author

Niklas and I discussed this topic and it seems there was a misunderstanding about this problem. Niklas proposed solution does not fix the problem. But I tried to use a FindMPI script which can control the MPI CXX interface via a variable, but this also did not work.
Handing it to you @Davknapp

@Davknapp Davknapp assigned sandro-elsweijer and unassigned Davknapp Aug 4, 2025
@Davknapp Davknapp added this pull request to the merge queue Aug 7, 2025
Merged via the queue into main with commit 86fff61 Aug 7, 2025
37 of 38 checks passed
@Davknapp Davknapp deleted the fix-openmpi_linkage branch August 7, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake Is about the CMake build system priority:medium Should be solved within half a year shouldn't take long Can be resolved in under 30 mins workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: OpenMPI linkage

3 participants