Skip to content

Bugfix: Extend valgrind suppression file by fortran related errors#1817

Merged
Davknapp merged 6 commits intomainfrom
extend_valgrind_suppression_file
Aug 5, 2025
Merged

Bugfix: Extend valgrind suppression file by fortran related errors#1817
Davknapp merged 6 commits intomainfrom
extend_valgrind_suppression_file

Conversation

@lenaploetzke
Copy link
Collaborator

@lenaploetzke lenaploetzke commented Aug 5, 2025

Closes #1818

Describe your changes here:

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.39%. Comparing base (b088294) to head (4b96f2a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1817   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files         101      101           
  Lines       19178    19178           
=======================================
  Hits        14268    14268           
  Misses       4910     4910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lenaploetzke lenaploetzke marked this pull request as ready for review August 5, 2025 09:17
@lenaploetzke lenaploetzke requested a review from Davknapp August 5, 2025 09:18
@Davknapp Davknapp assigned lenaploetzke and unassigned Davknapp Aug 5, 2025
@lenaploetzke lenaploetzke requested a review from Davknapp August 5, 2025 11:05
@lenaploetzke lenaploetzke assigned Davknapp and unassigned lenaploetzke Aug 5, 2025
@Davknapp Davknapp assigned lenaploetzke and unassigned Davknapp Aug 5, 2025
Co-authored-by: David Knapp <david.knapp@dlr.de>
@lenaploetzke lenaploetzke requested a review from Davknapp August 5, 2025 11:55
@lenaploetzke lenaploetzke assigned Davknapp and unassigned lenaploetzke Aug 5, 2025
@Davknapp Davknapp enabled auto-merge August 5, 2025 12:25
@Davknapp Davknapp added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 251538c Aug 5, 2025
38 checks passed
@Davknapp Davknapp deleted the extend_valgrind_suppression_file branch August 5, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugfix: Extend valgrind suppression file by fortran related errors

2 participants