Improvement: add context hooks in CMakeLists.txt#1838
Merged
sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom Sep 10, 2025
Merged
Improvement: add context hooks in CMakeLists.txt#1838sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom
sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 101 101
Lines 19190 19190
=======================================
Hits 14280 14280
Misses 4910 4910 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandro-elsweijer
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
This PR enables clearer configure logs when invoking CMake with
-DCMAKE_MESSAGE_CONTEXT_SHOW=ON: the logs feature a context prefix[p4est]or[sc]when configuring p4est and sc. This is purely opt-in, and composes nicely with downstream projects, which can use the same pattern to obtain[t8code.sc]for example.All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).