Improvement: Rename variables from t to element in t8 scheme default#1864
Merged
Davknapp merged 3 commits into1749-fix-t8_default_scheme-documentationfrom Sep 18, 2025
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1749-fix-t8_default_scheme-documentation #1864 +/- ##
============================================================================
- Coverage 74.41% 74.41% -0.01%
============================================================================
Files 101 101
Lines 19197 19192 -5
============================================================================
- Hits 14286 14282 -4
+ Misses 4911 4910 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Davknapp
approved these changes
Sep 18, 2025
Collaborator
|
Thanks a lot for upgrading the names! |
ee8c17b
into
1749-fix-t8_default_scheme-documentation
24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
Closes #1861
Rename variables from t to element in t8 scheme default. Additionally, this makes the variable naming of some functions in the .hxx and .cxx files consistent.
Hope that i catched all t's.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).