Improvement: clearer error message when creating a distributed cmesh#1874
Merged
sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom Sep 24, 2025
Merged
Improvement: clearer error message when creating a distributed cmesh#1874sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom
sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1874 +/- ##
=======================================
Coverage 74.42% 74.42%
=======================================
Files 101 101
Lines 19204 19204
=======================================
Hits 14293 14293
Misses 4911 4911 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandro-elsweijer
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
This PR adds a hint to fix the problem of creating distributed meshes with empty partitions, following a discussion with @holke. This problem could also be eliminated completely by performing an
MPI_[All]gatherand using that information to both propagate the information to the eventual empty partitions, as well as checking that all the partitions agree on the dimension. This robustness enhancement would definitely cost some CPU cycles though, but I don't have enough context to evaluate if this would be an acceptable tradeoff.All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).