Skip to content

Improvement: clearer error message when creating a distributed cmesh#1874

Merged
sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom
dutkalex:patch-2
Sep 24, 2025
Merged

Improvement: clearer error message when creating a distributed cmesh#1874
sandro-elsweijer merged 1 commit intoDLR-AMR:mainfrom
dutkalex:patch-2

Conversation

@dutkalex
Copy link
Contributor

@dutkalex dutkalex commented Sep 19, 2025

Describe your changes here:
This PR adds a hint to fix the problem of creating distributed meshes with empty partitions, following a discussion with @holke. This problem could also be eliminated completely by performing an MPI_[All]gather and using that information to both propagate the information to the eventual empty partitions, as well as checking that all the partitions agree on the dimension. This robustness enhancement would definitely cost some CPU cycles though, but I don't have enough context to evaluate if this would be an acceptable tradeoff.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.42%. Comparing base (b9633d6) to head (8d18de6).
⚠️ Report is 597 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1874   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files         101      101           
  Lines       19204    19204           
=======================================
  Hits        14293    14293           
  Misses       4911     4911           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandro-elsweijer sandro-elsweijer added this pull request to the merge queue Sep 24, 2025
Merged via the queue into DLR-AMR:main with commit b667ff1 Sep 24, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants