Improvement: Change location of CodeCoverage include in cmake #1880
Merged
lenaploetzke merged 7 commits intomainfrom Oct 6, 2025
Merged
Improvement: Change location of CodeCoverage include in cmake #1880lenaploetzke merged 7 commits intomainfrom
lenaploetzke merged 7 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1880 +/- ##
==========================================
+ Coverage 74.42% 75.54% +1.11%
==========================================
Files 101 103 +2
Lines 19204 19315 +111
==========================================
+ Hits 14293 14591 +298
+ Misses 4911 4724 -187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Davknapp
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1881
Describe your changes here:
The current location of the CodeCoverage.cmake include in the src cmake means that only the src folder is taken into account and coverage information is only collected for this folder. This causes problems when using templates, as no code is created here if the class is only used in tests, etc. Accordingly, we now also compile the remaining files with the --coverage option, which means that templated code is better taken into account. The test files and other files are, of course, excluded again for the creation of the codecoverage report.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).