Skip to content

Improvement: Custom competence test for mesh interface#1895

Merged
lenaploetzke merged 9 commits into1655-define-structure-of-the-unstructured-mesh-classfrom
interface-custom-competence-test
Oct 22, 2025
Merged

Improvement: Custom competence test for mesh interface#1895
lenaploetzke merged 9 commits into1655-define-structure-of-the-unstructured-mesh-classfrom
interface-custom-competence-test

Conversation

@lenaploetzke
Copy link
Collaborator

@lenaploetzke lenaploetzke commented Oct 15, 2025

Closes #1896

Describe your changes here:
The unstructured mesh interface allows the use of custom competences. A simple test is added for this.
Moreover there was a problem with the access specifier such that the caches were not actually used (because private members of course are not inherited). I need the public dummy functions because protected members cannot be used for the functionality to check if a cached version exists in the competences.
Lastly, the test is now faster because the get_centroid function is called less.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.62%. Comparing base (0cd9d49) to head (0d538bf).
⚠️ Report is 10 commits behind head on 1655-define-structure-of-the-unstructured-mesh-class.

Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           1655-define-structure-of-the-unstructured-mesh-class    #1895      +/-   ##
========================================================================================
- Coverage                                                 75.91%   75.62%   -0.30%     
========================================================================================
  Files                                                       105      106       +1     
  Lines                                                     19248    19387     +139     
========================================================================================
+ Hits                                                      14613    14662      +49     
- Misses                                                     4635     4725      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
Copy link
Member

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good to me :)

@lenaploetzke lenaploetzke merged commit c906f7b into 1655-define-structure-of-the-unstructured-mesh-class Oct 22, 2025
23 of 24 checks passed
@lenaploetzke lenaploetzke deleted the interface-custom-competence-test branch October 22, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Custom competence test for mesh interface

2 participants