Improvement: Custom competence test for mesh interface#1895
Merged
lenaploetzke merged 9 commits into1655-define-structure-of-the-unstructured-mesh-classfrom Oct 22, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1655-define-structure-of-the-unstructured-mesh-class #1895 +/- ##
========================================================================================
- Coverage 75.91% 75.62% -0.30%
========================================================================================
Files 105 106 +1
Lines 19248 19387 +139
========================================================================================
+ Hits 14613 14662 +49
- Misses 4635 4725 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
17 tasks
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
…nto interface-custom-competence-test
sandro-elsweijer
approved these changes
Oct 22, 2025
Member
sandro-elsweijer
left a comment
There was a problem hiding this comment.
Looks almost good to me :)
sandro-elsweijer
approved these changes
Oct 22, 2025
c906f7b
into
1655-define-structure-of-the-unstructured-mesh-class
23 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1896
Describe your changes here:
The unstructured mesh interface allows the use of custom competences. A simple test is added for this.
Moreover there was a problem with the access specifier such that the caches were not actually used (because private members of course are not inherited). I need the public dummy functions because protected members cannot be used for the functionality to check if a cached version exists in the competences.
Lastly, the test is now faster because the get_centroid function is called less.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).