Skip to content

Fix: Strong types#1933

Merged
Davknapp merged 4 commits intomainfrom
fix-strong_types
Oct 29, 2025
Merged

Fix: Strong types#1933
Davknapp merged 4 commits intomainfrom
fix-strong_types

Conversation

@sandro-elsweijer
Copy link
Member

@sandro-elsweijer sandro-elsweijer commented Oct 28, 2025

Closes #1935

Describe your changes here:
I observed two minor things in our strong types.

  1. the bool of is_reference has to be directly accessed by is_reference::value or is_reference_v.
  2. The std::move in get is not evaluated because we return a reference and it would also cast away the const. It gets re-consted by the return value but thats a little sketchy.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer added shouldn't take long Can be resolved in under 30 mins priority:medium Should be solved within half a year workload:low Would take half a day or less labels Oct 28, 2025
sandro-elsweijer and others added 2 commits October 28, 2025 12:50
Co-authored-by: David Knapp <david.knapp@dlr.de>
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.64%. Comparing base (8a48993) to head (1939610).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1933   +/-   ##
=======================================
  Coverage   75.64%   75.64%           
=======================================
  Files         103      103           
  Lines       18623    18623           
=======================================
  Hits        14087    14087           
  Misses       4536     4536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davknapp Davknapp enabled auto-merge October 28, 2025 14:07
@Davknapp Davknapp removed their assignment Oct 28, 2025
@Davknapp Davknapp added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit ac41a20 Oct 29, 2025
23 of 24 checks passed
@Davknapp Davknapp deleted the fix-strong_types branch October 29, 2025 10:40
@spenke91 spenke91 mentioned this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Should be solved within half a year shouldn't take long Can be resolved in under 30 mins workload:low Would take half a day or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Strong types

2 participants