Feature: Add dg competence to mesh handle by lenaploetzke · Pull Request #2321 · DLR-AMR/t8code

lenaploetzke · 2026-05-12T14:19:09Z

Closes #2322
Additionally Closes #2096 as the abort is deleted

Describe your changes here:

All these boxes must be checked by the AUTHOR before requesting review:

The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
If the PR is related to an issue, make sure to link it.
The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

The reviewer executed the new code features at least once and checked the results manually.
The code follows the t8code coding guidelines.
New source/header files are properly added to the CMake files.
The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

The code is covered in an existing or new test case using Google Test.
The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

Should this use case be added to the github action?
If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

The author added a BSD statement to doc/ (or already has one).

codecov · 2026-05-12T14:39:39Z

Codecov Report

❌ Patch coverage is 96.46018% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.71%. Comparing base (7c121bf) to head (2e1a160).

Files with missing lines	Patch %	Lines
mesh_handle/competences/dg_competences.hxx	96.33%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
+ Coverage   82.57%   82.71%   +0.14%     
==========================================
  Files         116      117       +1     
  Lines       18553    18665     +112     
==========================================
+ Hits        15320    15439     +119     
+ Misses       3233     3226       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

spenke91

As usual, the code design, its comments etc. are already very good 👍 -- and as usual, I just have some minor remarks and questions.

spenke91 · 2026-05-27T06:08:20Z

+    return requires (SelfType& mesh) { mesh.set_rank_vector (); };
+  }
+
+  /** Function that checks if a competence to determine a unique vector if the faces is given.


Suggested change

/** Function that checks if a competence to determine a unique vector if the faces is given.

/** Function that checks if a competence to determine a unique vector of the faces is given.

spenke91 · 2026-05-27T07:43:43Z

+   *                                         = remote rank of that ghost
+   */
+  void
+  set_rank_vector () const


I feel like the name set_rank_vector is slightly misleading as it implies a classical setter, meaning we set some member given an argument. How about populate_rank_vector, fill_rank_vector, compute_rank_vector, or build_rank_vector?

spenke91 · 2026-05-27T07:47:38Z

+  int rank = LOCAL_RANK;  ///< LOCAL_RANK if owned locally, else MPI rank of owner.
+};
+
+/** Class for a face. A face can have multiple \ref face_side s if different elements faces share the same face.


Suggested change

/** Class for a face. A face can have multiple \ref face_side s if different elements faces share the same face.

/** Class for a face. A face can have multiple \ref face_side s if different elements share the same face.

spenke91 · 2026-05-27T07:49:30Z

+  /** The face sides of different elements adjacent to this face. 
+   * Order conventions for the sides in the vector depend on the face type:
+   * - BOUNDARY: sides[0]     = the single local side
+   * - CONFORMAL / MPI_CONFORMAL: sides[0] = primary (smaller handle id); sides[1] = secondary.
+   *                              For MPI_CONFORMAL the local side is always the primary side with the smaller handle id (local ids < ghost ids).
+   * - MORTAR / MPI_MORTAR: sides[0] = large side; 
+   *                        sides[1..N] = small sides (in face-corner order of the large element)
+   */


Kudos for this very helpful comment ;-)

spenke91 · 2026-05-27T07:51:09Z

+ *      so the local side is always the one that inserts the face.
+ * - MORTAR / MPI_MORTAR: the large (coarser) side owns the face and inserts it (also for ghosts). 
+ *      The small sides are specified in sides.
+ * Additionally, a vector is build that holds the face indices for each element.


Suggested change

* Additionally, a vector is build that holds the face indices for each element.

* Additionally, a vector is built that holds the face indices for each element.

spenke91 · 2026-05-27T08:33:07Z

+              continue;  // local large side will insert the face, so we can skip this.
+            }
+
+            // Check if the ghost is already inserted by another small mortar. If yes, only add the face.


Suggested change

// Check if the ghost is already inserted by another small mortar. If yes, only add the face.

// Check if the ghost is already inserted by another small mortar. If yes, only add the face to the neighbor's \a sides array.

Or something like that? I feel like it should be made clearer what is meant by "only add the face"

spenke91 · 2026-05-27T08:35:07Z

+              continue;
+            }
+
+            const int orientation = t8_forest_leaf_face_orientation (


Suggested change

const int orientation = t8_forest_leaf_face_orientation (

// Add large mortar face (ghost) to \a m_faces and update \a m_element_face_vector.

const int orientation = t8_forest_leaf_face_orientation (

spenke91 · 2026-05-27T09:22:02Z

+    std::vector<int> dual_faces;
+    auto neighs = elem_first.get_face_neighbors (face.sides[0].local_face_id, dual_faces);
+    /* --- BOUNDARY --- */
+    if (face.type == face_type::BOUNDARY) {


I think a switch-case statement would look cleaner

Suggested change

if (face.type == face_type::BOUNDARY) {

switch (face.type) {

case face_type::BOUNDARY:

etc.

spenke91 · 2026-05-27T09:24:12Z

+      EXPECT_EQ (face.sides.size (), 1) << "BOUNDARY face must have exactly 1 side.";
+      EXPECT_EQ (face.sides[0].rank, LOCAL_RANK) << "BOUNDARY side must be local.";
+      EXPECT_FALSE (elem_first.is_ghost_element ()) << "BOUNDARY side element must be local.";
+      EXPECT_EQ (neighs.size (), 0) << "BOUNDARY side must not have neighbors.";
+      EXPECT_EQ (face.orientation,


Big fan of these "extended" EXPECT statements with descriptive messages :+1

spenke91 · 2026-05-27T09:27:20Z

+        << "MORTAR side must have as many neighbors as small sides of the face.";
+
+      for (int ineigh = 0; ineigh < static_cast<int> (neighs.size ()); ++ineigh) {
+        // The neighbors must not have the same order as the face sides.


Suggested change

// The neighbors must not have the same order as the face sides.

// The neighbors do not necessarily have the same order as the face sides.

lenaploetzke added 11 commits April 20, 2026 10:27

Rename file

8efb4e1

Merge branch 'new-handle-mesh-competences' into trace-face-vector

e863888

rename data handler

83395d1

ideas

6ad032d

changes to have vec with faces

5c209af

add remote rank functionality

cef3be5

new ideas

7ede1de

engineer function set unique face vector

a8beefe

add competences folder to test

22e01de

First working version of a test

1deb0a8

Merge branch 'new-handle-mesh-competences' into trace-face-vector

83eefbe

Base automatically changed from new-handle-mesh-competences to main May 13, 2026 09:21

lenaploetzke added 4 commits May 13, 2026 16:33

current status

1e1e5d5

Merge branch 'main' into trace-face-vector

be87678

Working test

604349c

documentation and orientation

2e1a160

spenke91 self-assigned this May 20, 2026

spenke91 self-requested a review May 20, 2026 13:09

spenke91 requested changes May 27, 2026

View reviewed changes

spenke91 assigned lenaploetzke and unassigned spenke91 May 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Add dg competence to mesh handle#2321

Feature: Add dg competence to mesh handle#2321
lenaploetzke wants to merge 15 commits into
mainfrom
trace-face-vector

lenaploetzke commented May 12, 2026 •

edited by spenke91

Loading

Uh oh!

codecov Bot commented May 12, 2026 •

edited

Loading

Uh oh!

spenke91 left a comment

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

spenke91 May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/** Function that checks if a competence to determine a unique vector if the faces is given.
	/** Function that checks if a competence to determine a unique vector of the faces is given.

	/** Class for a face. A face can have multiple \ref face_side s if different elements faces share the same face.
	/** Class for a face. A face can have multiple \ref face_side s if different elements share the same face.

	* Additionally, a vector is build that holds the face indices for each element.
	* Additionally, a vector is built that holds the face indices for each element.

	// Check if the ghost is already inserted by another small mortar. If yes, only add the face.
	// Check if the ghost is already inserted by another small mortar. If yes, only add the face to the neighbor's \a sides array.

	const int orientation = t8_forest_leaf_face_orientation (
	// Add large mortar face (ghost) to \a m_faces and update \a m_element_face_vector.
	const int orientation = t8_forest_leaf_face_orientation (

	if (face.type == face_type::BOUNDARY) {
	switch (face.type) {
	case face_type::BOUNDARY:

	// The neighbors must not have the same order as the face sides.
	// The neighbors do not necessarily have the same order as the face sides.

Conversation

lenaploetzke commented May 12, 2026 • edited by spenke91 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

General

Tests

Scripts and Wiki

License

Uh oh!

codecov Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

spenke91 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lenaploetzke commented May 12, 2026 •

edited by spenke91

Loading

codecov Bot commented May 12, 2026 •

edited

Loading