Merged
Conversation
…f the feature "shutdown-on-deadlock" is defined, and is activated as a default feature for now. Shutdowns are now timed to take a maximum of 60 seconds, instead of 300 seconds. DMDcoin#231 Code Infrastructure changes: ShutdownManager is now hosted as an Arc.
…down routine is unable to finish all work, for example because of deadlocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#231 shutdown on deadlock
On detecting a deadlock, we are shutting down the Node Software now if the feature "shutdown-on-deadlock" is defined, and is activated as a default feature for now.
Shutdowns are now timed to take a maximum of 60 seconds, instead of 300 seconds. Code Infrastructure changes: ShutdownManager is now hosted as an Arc.
Feature Enhancements:
Cargo.toml: Added a new feature flagshutdown-on-deadlock, which enables deadlock detection by leveraging theparking_lot/deadlock_detectionfeature. This is now part of the default feature set. [1] [2]Code Refactoring:
crates/ethcore/service/src/service.rs: Updated theshutdownfield in theClientServiceconstructor to useArc<ShutdownManager>instead ofShutdownManagerfor better thread safety.crates/ethcore/src/client/client.rs: Refactored theshutdownfield in theClientstruct and its constructor to useArc<ShutdownManager>, ensuring consistent shared ownership across threads. [1] [2]