Skip to content

phoenix protocol#292

Merged
SurfingNerd merged 13 commits into0.12from
dfo/phoenix-protocol
Oct 6, 2025
Merged

phoenix protocol#292
SurfingNerd merged 13 commits into0.12from
dfo/phoenix-protocol

Conversation

@dforsten
Copy link
Collaborator

@dforsten dforsten commented Oct 5, 2025

@dforsten dforsten changed the title phoenix protocol #52 phoenix protocol DMDcoin/openethereum-3.x#52 Oct 5, 2025
@dforsten dforsten changed the title phoenix protocol DMDcoin/openethereum-3.x#52 phoenix protocol Oct 5, 2025
@SurfingNerd SurfingNerd changed the base branch from main to 0.12 October 5, 2025 09:00
@SurfingNerd SurfingNerd requested a review from Copilot October 5, 2025 09:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a "Phoenix Protocol" for the HBBFT consensus engine to detect and recover from stalled consensus situations. The protocol monitors block production timing and performs controlled recovery by temporarily deferring outgoing messages, resetting the HoneyBadger consensus instance, and then resuming normal operation.

Key changes:

  • Adds a periodic timer-based recovery mechanism that triggers when no new blocks are produced for a configurable time period
  • Implements message deferral and storage capabilities to temporarily hold outgoing consensus messages during recovery
  • Provides a reset mechanism for the underlying HoneyBadger consensus instance while preserving other state

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
crates/ethcore/src/engines/hbbft/hbbft_state.rs Adds reset_honeybadger method to reset only the HoneyBadger instance while preserving network info
crates/ethcore/src/engines/hbbft/hbbft_engine.rs Implements the Phoenix Protocol with timer-based monitoring, message deferral, and recovery logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Every re-try gets 2 minutes more time to create the block.
The first 2 minutes validators receive but do not send hbbft messages. This is to account for up to 2 minutes timing differences between validators.
@SurfingNerd SurfingNerd merged commit d1eeb05 into 0.12 Oct 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants