Skip to content

I290 key gen optimizations#293

Merged
SurfingNerd merged 5 commits intoDMDcoin:0.12from
SurfingNerd:i290-key-gen-optimizations
Oct 5, 2025
Merged

I290 key gen optimizations#293
SurfingNerd merged 5 commits intoDMDcoin:0.12from
SurfingNerd:i290-key-gen-optimizations

Conversation

@SurfingNerd
Copy link
Collaborator

@SurfingNerd SurfingNerd commented Oct 5, 2025

- ignores transactions already in the Queue
- could lead to closing of nonce gaps
- overwrites other service transactions
- possibility that the service transaction is not written, because another one is already inflight.
…ped, Rejected, Replaced, Invalid or Canceled.
@SurfingNerd SurfingNerd requested a review from Copilot October 5, 2025 12:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements optimizations for key generation transactions in the HBBFT consensus engine. The changes include better transaction tracking, improved nonce management, and reduced log verbosity.

  • Adds local transaction status checking to monitor keygen transaction states
  • Improves nonce management by using latest block nonce instead of queued transactions
  • Reduces log verbosity by changing some warn/error logs to debug level

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
crates/rpc/src/v1/tests/helpers/miner_service.rs Implements local_transaction_status method for test miner service
crates/ethcore/sync/src/chain/propagator.rs Changes log level from warn to debug for peer connection messages
crates/ethcore/src/miner/mod.rs Adds local_transaction_status method to MinerService trait
crates/ethcore/src/miner/miner.rs Implements local_transaction_status method in Miner
crates/ethcore/src/engines/hbbft/keygen_transactions.rs Major refactoring with transaction tracking, nonce management improvements, and delay configuration
crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs Changes log levels from warn/error to debug
crates/ethcore/src/engines/hbbft/hbbft_engine.rs Updates service name and adds configurable delay parameters
crates/ethcore/src/engines/hbbft/contracts/validator_set.rs Adds Debug trait to KeyGenMode enum
crates/ethcore/src/client/traits.rs Adds local_transaction_status method to EngineClient trait
crates/ethcore/src/client/test_client.rs Implements local_transaction_status for test client
crates/ethcore/src/client/client.rs Adds local transaction status methods to Client
crates/concensus/miner/src/pool/queue.rs Implements local_transaction_status method in TransactionQueue
Comments suppressed due to low confidence (2)

crates/ethcore/src/engines/hbbft/keygen_transactions.rs:1

  • Misspelled 'configurable' as 'configureable'.
use crate::{

crates/ethcore/src/engines/hbbft/keygen_transactions.rs:1

  • Misspelled 'interpret' as 'interprate'.
use crate::{

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SurfingNerd SurfingNerd merged commit c2694c6 into DMDcoin:0.12 Oct 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants