Skip to content

clang-tidy C++11 modernization changes#2535

Merged
jwillemsen merged 11 commits intoDOCGroup:masterfrom
jwillemsen:jwi-nullptr3
May 6, 2026
Merged

clang-tidy C++11 modernization changes#2535
jwillemsen merged 11 commits intoDOCGroup:masterfrom
jwillemsen:jwi-nullptr3

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Too many files!

This PR contains 300 files, which is 150 over the limit of 150.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5cc8a771-5215-48cd-a654-cd78b40058fd

📥 Commits

Reviewing files that changed from the base of the PR and between 23aa678 and 768c56d.

📒 Files selected for processing (300)
  • ACE/ace/ACE.h
  • ACE/ace/ARGV.h
  • ACE/ace/Abstract_Timer_Queue.h
  • ACE/ace/Acceptor.h
  • ACE/ace/Active_Map_Manager_T.h
  • ACE/ace/Arg_Shifter.h
  • ACE/ace/Array_Base.h
  • ACE/ace/Array_Map.h
  • ACE/ace/Asynch_Acceptor.h
  • ACE/ace/Asynch_Connector.h
  • ACE/ace/Asynch_IO.h
  • ACE/ace/Asynch_IO_Impl.h
  • ACE/ace/Asynch_Pseudo_Task.h
  • ACE/ace/Atomic_Op_T.h
  • ACE/ace/Auto_Functor.h
  • ACE/ace/Based_Pointer_Repository.h
  • ACE/ace/Basic_Stats.h
  • ACE/ace/Basic_Types.h
  • ACE/ace/Bound_Ptr.h
  • ACE/ace/CDR_Base.h
  • ACE/ace/CDR_Stream.h
  • ACE/ace/Cache_Map_Manager_T.h
  • ACE/ace/Cached_Connect_Strategy_T.h
  • ACE/ace/Caching_Strategies_T.h
  • ACE/ace/Caching_Utility_T.h
  • ACE/ace/Capabilities.h
  • ACE/ace/Cleanup.h
  • ACE/ace/Codeset_Registry.h
  • ACE/ace/Condition_Recursive_Thread_Mutex.h
  • ACE/ace/Condition_T.h
  • ACE/ace/Condition_Thread_Mutex.h
  • ACE/ace/Configuration.h
  • ACE/ace/Configuration_Import_Export.h
  • ACE/ace/Connection_Recycling_Strategy.h
  • ACE/ace/Connector.h
  • ACE/ace/Containers.h
  • ACE/ace/Containers_T.h
  • ACE/ace/Countdown_Time.h
  • ACE/ace/DEV_Addr.h
  • ACE/ace/DEV_Connector.h
  • ACE/ace/DEV_IO.h
  • ACE/ace/DLL_Manager.h
  • ACE/ace/Dev_Poll_Reactor.h
  • ACE/ace/Dump_T.h
  • ACE/ace/Dynamic_Message_Strategy.h
  • ACE/ace/Event.h
  • ACE/ace/Event_Handler.h
  • ACE/ace/Event_Handler_T.h
  • ACE/ace/FILE_Addr.h
  • ACE/ace/FILE_Connector.h
  • ACE/ace/FILE_IO.h
  • ACE/ace/Filecache.h
  • ACE/ace/Framework_Component_T.h
  • ACE/ace/Functor.h
  • ACE/ace/Functor_T.h
  • ACE/ace/Future.h
  • ACE/ace/Future_Set.h
  • ACE/ace/Global_Macros.h
  • ACE/ace/Guard_T.h
  • ACE/ace/Handle_Gobbler.h
  • ACE/ace/Hash_Cache_Map_Manager_T.h
  • ACE/ace/Hash_Map_Manager_T.h
  • ACE/ace/Hash_Multi_Map_Manager_T.h
  • ACE/ace/High_Res_Timer.h
  • ACE/ace/INET_Addr.h
  • ACE/ace/IO_Cntl_Msg.h
  • ACE/ace/If_Then_Else.h
  • ACE/ace/Intrusive_Auto_Ptr.h
  • ACE/ace/LSOCK_Acceptor.h
  • ACE/ace/LSOCK_Connector.h
  • ACE/ace/LSOCK_Stream.h
  • ACE/ace/Local_Memory_Pool.h
  • ACE/ace/Local_Name_Space_T.h
  • ACE/ace/Lock.h
  • ACE/ace/Lock_Adapter_T.h
  • ACE/ace/Log_Msg.h
  • ACE/ace/Log_Msg_IPC.h
  • ACE/ace/MEM_Acceptor.h
  • ACE/ace/MEM_Addr.h
  • ACE/ace/MEM_Connector.h
  • ACE/ace/MEM_IO.h
  • ACE/ace/MEM_SAP.h
  • ACE/ace/MEM_Stream.h
  • ACE/ace/MMAP_Memory_Pool.h
  • ACE/ace/Malloc_Allocator.h
  • ACE/ace/Malloc_Base.h
  • ACE/ace/Malloc_T.h
  • ACE/ace/Managed_Object.h
  • ACE/ace/Map_Manager.h
  • ACE/ace/Map_T.h
  • ACE/ace/Message_Block.h
  • ACE/ace/Message_Block_T.h
  • ACE/ace/Message_Queue_T.h
  • ACE/ace/Module.h
  • ACE/ace/Monitor_Admin.h
  • ACE/ace/Monitor_Admin_Manager.h
  • ACE/ace/Monitor_Base.h
  • ACE/ace/Monitor_Control_Types.h
  • ACE/ace/Monitor_Point_Registry.h
  • ACE/ace/Multihomed_INET_Addr.h
  • ACE/ace/Mutex.h
  • ACE/ace/Name_Proxy.h
  • ACE/ace/Name_Space.h
  • ACE/ace/Naming_Context.h
  • ACE/ace/Netlink_Addr.h
  • ACE/ace/Notification_Queue.h
  • ACE/ace/Null_Condition.h
  • ACE/ace/OS_Memory.h
  • ACE/ace/OS_NS_Thread.h
  • ACE/ace/OS_NS_stdlib.h
  • ACE/ace/OS_NS_stropts.h
  • ACE/ace/OS_NS_sys_stat.h
  • ACE/ace/OS_NS_sys_utsname.h
  • ACE/ace/OS_NS_time.h
  • ACE/ace/OS_NS_wchar.h
  • ACE/ace/OS_QoS.h
  • ACE/ace/OS_TLI.h
  • ACE/ace/OS_Thread_Adapter.h
  • ACE/ace/Object_Manager.h
  • ACE/ace/Object_Manager_Base.h
  • ACE/ace/Obstack.h
  • ACE/ace/PI_Malloc.h
  • ACE/ace/POSIX_Asynch_IO.h
  • ACE/ace/POSIX_CB_Proactor.h
  • ACE/ace/POSIX_Proactor.h
  • ACE/ace/Pair_T.h
  • ACE/ace/Parse_Node.h
  • ACE/ace/Ping_Socket.h
  • ACE/ace/Priority_Reactor.h
  • ACE/ace/Proactor.h
  • ACE/ace/Proactor_Impl.h
  • ACE/ace/Process_Manager.h
  • ACE/ace/Profile_Timer.h
  • ACE/ace/RB_Tree.h
  • ACE/ace/RW_Mutex.h
  • ACE/ace/RW_Process_Mutex.h
  • ACE/ace/RW_Thread_Mutex.h
  • ACE/ace/Reactor.h
  • ACE/ace/Reactor_Impl.h
  • ACE/ace/Reactor_Notification_Strategy.h
  • ACE/ace/Reactor_Timer_Interface.h
  • ACE/ace/Read_Buffer.h
  • ACE/ace/Recursive_Thread_Mutex.h
  • ACE/ace/Refcounted_Auto_Ptr.h
  • ACE/ace/Remote_Name_Space.h
  • ACE/ace/Reverse_Lock_T.h
  • ACE/ace/SOCK_Acceptor.h
  • ACE/ace/SOCK_CODgram.h
  • ACE/ace/SOCK_Connector.h
  • ACE/ace/SOCK_Dgram.h
  • ACE/ace/SOCK_SEQPACK_Acceptor.h
  • ACE/ace/SOCK_SEQPACK_Association.h
  • ACE/ace/SOCK_SEQPACK_Connector.h
  • ACE/ace/SOCK_Stream.h
  • ACE/ace/SPIPE_Acceptor.h
  • ACE/ace/SPIPE_Addr.h
  • ACE/ace/SPIPE_Connector.h
  • ACE/ace/SPIPE_Stream.h
  • ACE/ace/SSL/SSL_Asynch_BIO.cpp
  • ACE/ace/SSL/SSL_Asynch_Stream.cpp
  • ACE/ace/SSL/SSL_Asynch_Stream.h
  • ACE/ace/SSL/SSL_Context.cpp
  • ACE/ace/SSL/SSL_Context.h
  • ACE/ace/SSL/SSL_Initializer.cpp
  • ACE/ace/SSL/SSL_SOCK_Acceptor.cpp
  • ACE/ace/SSL/SSL_SOCK_Acceptor.h
  • ACE/ace/SSL/SSL_SOCK_Connector.cpp
  • ACE/ace/SSL/SSL_SOCK_Connector.h
  • ACE/ace/SSL/SSL_SOCK_Stream.cpp
  • ACE/ace/SSL/SSL_SOCK_Stream.h
  • ACE/ace/SString.h
  • ACE/ace/SStringfwd.h
  • ACE/ace/Sample_History.h
  • ACE/ace/Sbrk_Memory_Pool.h
  • ACE/ace/Sched_Params.h
  • ACE/ace/Select_Reactor.h
  • ACE/ace/Select_Reactor_Base.h
  • ACE/ace/Select_Reactor_T.h
  • ACE/ace/Service_Config.h
  • ACE/ace/Service_Gestalt.h
  • ACE/ace/Service_Manager.h
  • ACE/ace/Service_Object.h
  • ACE/ace/Service_Repository.h
  • ACE/ace/Service_Types.h
  • ACE/ace/Shared_Memory_MM.h
  • ACE/ace/Shared_Memory_Pool.h
  • ACE/ace/Shared_Memory_SV.h
  • ACE/ace/Singleton.h
  • ACE/ace/Strategies_T.h
  • ACE/ace/String_Base.h
  • ACE/ace/String_Base_Const.h
  • ACE/ace/Svc_Conf.h
  • ACE/ace/Svc_Conf_Token_Table.h
  • ACE/ace/Svc_Handler.h
  • ACE/ace/Synch_Traits.h
  • ACE/ace/System_Time.h
  • ACE/ace/TP_Reactor.h
  • ACE/ace/Task.h
  • ACE/ace/Task_Ex_T.h
  • ACE/ace/Task_T.h
  • ACE/ace/Test_and_Set.h
  • ACE/ace/Thread_Adapter.h
  • ACE/ace/Thread_Manager.h
  • ACE/ace/Time_Policy.h
  • ACE/ace/Time_Policy_T.h
  • ACE/ace/Time_Value_T.h
  • ACE/ace/Timer_Hash.h
  • ACE/ace/Timer_Hash_T.h
  • ACE/ace/Timer_Heap.h
  • ACE/ace/Timer_Heap_T.h
  • ACE/ace/Timer_List.h
  • ACE/ace/Timer_List_T.h
  • ACE/ace/Timer_Queue.h
  • ACE/ace/Timer_Queue_Adapters.h
  • ACE/ace/Timer_Queue_Iterator.h
  • ACE/ace/Timer_Queue_T.h
  • ACE/ace/Timer_Queuefwd.h
  • ACE/ace/Timer_Wheel.h
  • ACE/ace/Timer_Wheel_T.h
  • ACE/ace/Tokenizer_T.h
  • ACE/ace/Truncate.h
  • ACE/ace/UNIX_Addr.h
  • ACE/ace/UPIPE_Acceptor.h
  • ACE/ace/UPIPE_Addr.h
  • ACE/ace/UPIPE_Connector.h
  • ACE/ace/UPIPE_Stream.h
  • ACE/ace/UUID.h
  • ACE/ace/Unbounded_Queue.h
  • ACE/ace/Unbounded_Set.h
  • ACE/ace/Unbounded_Set_Ex.h
  • ACE/ace/Vector_T.h
  • ACE/ace/ace_wchar.h
  • ACE/ace/config-macros.h
  • ACE/apps/gperf/src/Bool_Array.cpp
  • ACE/apps/gperf/src/Gen_Perf.cpp
  • ACE/apps/gperf/src/Hash_Table.cpp
  • ACE/apps/gperf/src/Key_List.cpp
  • ACE/apps/gperf/src/List_Node.cpp
  • ACE/apps/gperf/src/Options.cpp
  • ACE/tests/ACE_Test.cpp
  • ACE/tests/ARGV_Test.cpp
  • ACE/tests/Array_Map_Test.cpp
  • ACE/tests/Auto_Event_Test.cpp
  • ACE/tests/Auto_IncDec_Test.cpp
  • ACE/tests/Barrier_Test.cpp
  • ACE/tests/Based_Pointer_Test.cpp
  • ACE/tests/Bound_Ptr_Test.cpp
  • ACE/tests/Buffer_Stream_Test.cpp
  • ACE/tests/Bug_1576_Regression_Test.cpp
  • ACE/tests/Bug_1890_Regression_Test.cpp
  • ACE/tests/Bug_2368_Regression_Test.cpp
  • ACE/tests/Bug_2497_Regression_Test.cpp
  • ACE/tests/Bug_2540_Regression_Test.cpp
  • ACE/tests/Bug_2609_Regression_Test.cpp
  • ACE/tests/Bug_2610_Regression_Test.cpp
  • ACE/tests/Bug_2659_Regression_Test.cpp
  • ACE/tests/Bug_2740_Regression_Test.cpp
  • ACE/tests/Bug_2772_Regression_Test.cpp
  • ACE/tests/Bug_2815_Regression_Test.cpp
  • ACE/tests/Bug_2820_Regression_Test.cpp
  • ACE/tests/Bug_2975_Regression_Test.cpp
  • ACE/tests/Bug_2980_Regression_Test.cpp
  • ACE/tests/Bug_3319_Regression_Test.cpp
  • ACE/tests/Bug_3332_Regression_Test.cpp
  • ACE/tests/Bug_3432_Regression_Test.cpp
  • ACE/tests/Bug_3539_Regression_Test.cpp
  • ACE/tests/Bug_3729_Regression_Test.cpp
  • ACE/tests/Bug_3878_Regression_Test.cpp
  • ACE/tests/Bug_3911_Regression_Test.cpp
  • ACE/tests/Bug_3912_Regression_Test.cpp
  • ACE/tests/Bug_3943_Regression_Test.cpp
  • ACE/tests/Bug_4055_Regression_Test.cpp
  • ACE/tests/Bug_4189_Regression_Test.cpp
  • ACE/tests/CDR_Array_Test.cpp
  • ACE/tests/CDR_File_Test.cpp
  • ACE/tests/CDR_Test.cpp
  • ACE/tests/Cache_Map_Manager_Test.cpp
  • ACE/tests/Cached_Accept_Conn_Test.cpp
  • ACE/tests/Cached_Allocator_Test.cpp
  • ACE/tests/Cached_Conn_Test.cpp
  • ACE/tests/Codecs_Test.cpp
  • ACE/tests/Collection_Test.cpp
  • ACE/tests/Compiler_Features_13_Test.cpp
  • ACE/tests/Compiler_Features_37_Test.cpp
  • ACE/tests/Compiler_Features_43_Test.cpp
  • ACE/tests/Config_Test.cpp
  • ACE/tests/Conn_Test.cpp
  • ACE/tests/DLL_Test.cpp
  • ACE/tests/DLList_Test.cpp
  • ACE/tests/Dev_Poll_Reactor_Echo_Test.cpp
  • ACE/tests/Dev_Poll_Reactor_Test.cpp
  • ACE/tests/Dirent_Test.cpp
  • ACE/tests/Dynamic_Test.cpp
  • ACE/tests/Enum_Interfaces_Test.cpp
  • ACE/tests/FIFO_Test.cpp
  • ACE/tests/FlReactor_Test.cpp
  • ACE/tests/Framework_Component_Test.cpp
  • ACE/tests/Future_Set_Test.cpp
  • ACE/tests/Future_Stress_Test.cpp
  • ACE/tests/Future_Test.cpp

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 5, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@jwillemsen jwillemsen changed the title Use nullptr instead of 0 (clang-tidy changes) clang-tidy C++11 modernization changes May 5, 2026
jwillemsen added 5 commits May 5, 2026 17:37
    * ACE/ace/CDR_Base.h:
    * ACE/ace/OS_NS_wchar.h:
    * ACE/ace/SStringfwd.h:
    * ACE/ace/Cache_Map_Manager_T.h:
    * ACE/ace/OS_NS_signal.h:
…ion, is nullptr on linux, windows on other platforms

    * ACE/ace/config-macros.h:
    * ACE/tests/Bug_2740_Regression_Test.cpp:
    * ACE/tests/Bug_3539_Regression_Test.cpp:
    * ACE/tests/Bug_4189_Regression_Test.cpp:
    * ACE/tests/Dev_Poll_Reactor_Test.cpp:
    * ACE/tests/MEM_Stream_Test.cpp:
    * ACE/tests/Message_Queue_Test_Ex.cpp:
    * ACE/tests/Reactor_Fairness_Test.cpp:
    * ACE/tests/Recursive_Condition_Test.cpp:
    * ACE/tests/SOCK_Dgram_Bcast_Test.cpp:
    * ACE/tests/SOCK_SEQPACK_SCTP_Test.cpp:
    * ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp:
    * ACE/tests/SSL/Thread_Pool_Reactor_SSL_Test.cpp:
    * ACE/tests/Service_Config_DLL.cpp:
    * ACE/tests/Service_Config_Test.cpp:
    * ACE/tests/Signal_Test.cpp:
    * ACE/tests/Task_Ex_Test.cpp:
    * ACE/tests/Thread_Pool_Reactor_Resume_Test.cpp:
    * ACE/tests/Thread_Pool_Reactor_Test.cpp:
    * ACE/tests/Based_Pointer_Test.cpp:
    * ACE/tests/Bug_2659_Regression_Test.cpp:
    * ACE/tests/Bug_2740_Regression_Test.cpp:
    * ACE/tests/Bug_2815_Regression_Test.cpp:
    * ACE/tests/Bug_2820_Regression_Test.cpp:
    * ACE/tests/Bug_2975_Regression_Test.cpp:
    * ACE/tests/Bug_3319_Regression_Test.cpp:
    * ACE/tests/Bug_3878_Regression_Test.cpp:
    * ACE/tests/Bug_4055_Regression_Test.cpp:
    * ACE/tests/Config_Test.cpp:
    * ACE/tests/DLL_Test.cpp:
    * ACE/tests/Dev_Poll_Reactor_Echo_Test.cpp:
    * ACE/tests/Dev_Poll_Reactor_Test.cpp:
    * ACE/tests/Framework_Component_Test.cpp:
    * ACE/tests/Log_Msg_Test.cpp:
    * ACE/tests/Log_Thread_Inheritance_Test.cpp:
    * ACE/tests/MT_Reactor_Timer_Test.cpp:
    * ACE/tests/MT_Reference_Counted_Notify_Test.cpp:
    * ACE/tests/Malloc_Test.cpp:
    * ACE/tests/Map_Manager_Test.cpp:
    * ACE/tests/NonBlocking_Conn_Test.cpp:
    * ACE/tests/Proactor_Test.cpp:
    * ACE/tests/Proactor_Test_IPV6.cpp:
    * ACE/tests/Proactor_UDP_Test.cpp:
    * ACE/tests/Process_Manager_Test.cpp:
    * ACE/tests/Reactor_Fairness_Test.cpp:
    * ACE/tests/Reactor_Notification_Queue_Test.cpp:
    * ACE/tests/Reactor_Performance_Test.cpp:
    * ACE/tests/Reactor_Registration_Test.cpp:
    * ACE/tests/Recursive_Mutex_Test.cpp:
    * ACE/tests/Reference_Counted_Event_Handler_Test.cpp:
    * ACE/tests/SOCK_Dgram_Bcast_Test.cpp:
    * ACE/tests/SString_Test.cpp:
    * ACE/tests/Service_Config_Test.cpp:
    * ACE/tests/Test_Output.cpp:
    * ACE/tests/Thread_Mutex_Test.cpp:
    * ACE/tests/Token_Strategy_Test.cpp:
@jwillemsen jwillemsen merged commit b86aaf6 into DOCGroup:master May 6, 2026
38 of 39 checks passed
@jwillemsen jwillemsen deleted the jwi-nullptr3 branch May 6, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant