Skip to content

Add missing override#2538

Merged
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-missingovveride
May 7, 2026
Merged

Add missing override#2538
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-missingovveride

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented May 7, 2026

* ACE/ace/Strategies_T.h:

Summary by CodeRabbit

  • Style
    • Updated internal code declarations to follow modern C++ best practices for improved code consistency and clarity.

    * ACE/ace/Strategies_T.h:
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4dfacf5a-6372-4cc2-bf7f-950a2dae8e66

📥 Commits

Reviewing files that changed from the base of the PR and between 273591d and b7cdd60.

📒 Files selected for processing (1)
  • ACE/ace/Strategies_T.h

Walkthrough

This PR adds C++11 override specifiers to two connect_svc_handler method declarations in ACE_Cached_Connect_Strategy. The declarations replace virtual with explicit override, clarifying that these methods override base-class virtual functions without changing functionality.

Changes

Method Override Specifier Update

Layer / File(s) Summary
Method Declaration Updates
ACE/ace/Strategies_T.h
Two connect_svc_handler overload declarations are marked with override specifier, replacing virtual-only declarations to explicitly indicate base-class virtual method overrides.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through template code with glee, 🐰
Adding override—"now all can see!"
No bugs, no breaks, just clarity divine,
C++11 makes inheritance align. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add missing override' is directly related to the main change: adding the C++11 override specifier to two connect_svc_handler method declarations in ACE_Cached_Connect_Strategy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@jwillemsen jwillemsen merged commit addda44 into DOCGroup:master May 7, 2026
38 checks passed
@jwillemsen jwillemsen deleted the jwi-missingovveride branch May 7, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant