Skip to content

Remove obsolete old_stdstream feature#2543

Merged
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-oldstdstrem
May 19, 2026
Merged

Remove obsolete old_stdstream feature#2543
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-oldstdstrem

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented May 19, 2026

* ACE/bin/MakeProjectCreator/config/global.features:
* ACE/bin/MakeProjectCreator/config/inet.mpb:
* ACE/protocols/ace/INet/inet.mpc:

Summary by CodeRabbit

  • Chores
    • Removed obsolete build configuration flags to streamline the build system configuration and reduce maintenance overhead of legacy features.

Review Change Stack

    * ACE/bin/MakeProjectCreator/config/global.features:
    * ACE/bin/MakeProjectCreator/config/inet.mpb:
    * ACE/protocols/ace/INet/inet.mpc:
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a810ba28-0983-4ed2-a2dd-c97a9a286568

📥 Commits

Reviewing files that changed from the base of the PR and between acb6815 and 4be510c.

📒 Files selected for processing (3)
  • ACE/bin/MakeProjectCreator/config/global.features
  • ACE/bin/MakeProjectCreator/config/inet.mpb
  • ACE/protocols/ace/INet/inet.mpc
💤 Files with no reviewable changes (3)
  • ACE/bin/MakeProjectCreator/config/inet.mpb
  • ACE/bin/MakeProjectCreator/config/global.features
  • ACE/protocols/ace/INet/inet.mpc

Walkthrough

This PR removes deprecated old_stdstream feature flag references from ACE build configuration files across global defaults and project-specific avoidance settings without affecting other feature flags or directives.

Changes

old_stdstream deprecation cleanup

Layer / File(s) Summary
Remove old_stdstream from feature defaults and project configs
ACE/bin/MakeProjectCreator/config/global.features, ACE/bin/MakeProjectCreator/config/inet.mpb, ACE/protocols/ace/INet/inet.mpc
Removed old_stdstream = 0 from global feature defaults and removed avoids += old_stdstream directives from acelib and INet project definitions, leaving all other features and avoidance entries unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A rabbit hops through old code with glee,
Sweeping out flags that no longer need be,
Three simple removals, clean and true—
The build system sighs: "Thanks, I feel new!" 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: removing the obsolete old_stdstream feature across three configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@jwillemsen jwillemsen merged commit 35d84b4 into DOCGroup:master May 19, 2026
39 checks passed
@jwillemsen jwillemsen deleted the jwi-oldstdstrem branch May 19, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant