ACE_Process std file handles on Windows by mitza-oci · Pull Request #6 · DOCGroup/ACE_TAO

mitza-oci · 2015-02-10T20:41:12Z

Allow redirection of child's stdout/stderr when there is no
stdin handle available (for example when running in a service).
TAO_IDL drv_preproc: check for errors from ACE_Process

Allow redirection of child's stdout/stderr when there is no stdin handle available (for example when running in a service). TAO_IDL drv_preproc: check for errors from ACE_Process

jwillemsen · 2015-02-11T08:06:47Z

Given that prog_name() returns a char* why not log using %C, that way ACE_TEXT_CHAR_TO_TCHAR is not needed at all

It was copied from the other logging in that file when the patch started out in TAO 1.6a. I'll update it.

Thanks, could you at the same moment check the other occurences of prog_name() logging? Then all are consistent.

The other uses in drv_preproc.cpp are OK. The remaining inconsistent ones are in drv_args.cpp and tao_id.cpp.

…file.

…to %C.

jwillemsen · 2015-02-11T15:18:11Z

Did a quick google search and according to Microsoft documentation handle 0 is equal to keyboard input (http://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-us/redirection.mspx?mfr=true)

mitza-oci · 2015-02-11T15:23:05Z

That's true for cmd shell but it doesn't seem to apply at the OS API. https://msdn.microsoft.com/en-us/library/windows/desktop/ms683231%28v=vs.85%29.aspx "If an application does not have associated standard handles, such as a service running on an interactive desktop, and has not redirected them, the return value is NULL."

jwillemsen · 2015-02-11T15:24:22Z

Ok, thanks for the link, at the moment the travis ci build also has no problems feel free to merge the pull request

ACE_Process std file handles on Windows

Under extreme multi-thread log load tests found that occasionally two threads would lock up on macOS, with one thread reporting EXC_BAD_ACCESS. In our load test environment this happened after about 20 hours of testing. This patch ensures that no log messages are written at the same time as this->log_msg_->msg_ostream()->tell()` Stack trace of log rotation thread getting EXC_BAD_ACCESS on `fwrite()` due to `this->log_msg_->msg_ostream()->tell()`: ``` * thread DOCGroup#1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) * frame #0: 0x00007ff81884b222 libsystem_platform.dylib`_platform_memmove$VARIANT$Haswell + 194 frame DOCGroup#1: 0x00007ff81870833b libsystem_c.dylib`__sfvwrite + 382 frame DOCGroup#2: 0x00007ff818729d0c libsystem_c.dylib`fwrite + 136 frame DOCGroup#3: 0x0000000106a3dabe NetSequencer`std::__1::basic_filebuf<char, std::__1::char_traits<char> >::overflow(this=0x00007f80f3204328, __c=-1) at fstream:823:17 frame DOCGroup#4: 0x0000000106a3cf31 NetSequencer`std::__1::basic_filebuf<char, std::__1::char_traits<char> >::sync(this=0x00007f80f3204328) at fstream:988:17 frame DOCGroup#5: 0x0000000106a3caf8 NetSequencer`std::__1::basic_filebuf<char, std::__1::char_traits<char> >::seekoff(this=0x00007f80f3204328, __off=0, __way=cur, (null)=16) at fstream:928:63 frame DOCGroup#6: 0x0000000107b122c3 NetSequencer`std::__1::basic_streambuf<char, std::__1::char_traits<char> >::pubseekoff(this=0x00007f80f3204328, __off=0, __way=cur, __which=16) at streambuf:159:14 frame DOCGroup#7: 0x0000000107b1109b NetSequencer`std::__1::basic_ostream<char, std::__1::char_traits<char> >::tellp(this=0x00007f80f3204320) at ostream:960:27 frame DOCGroup#8: 0x0000000107b10b97 NetSequencer`ACE_Logging_Strategy::handle_timeout(this=0x00006000012f01b0, (null)=0x00007ff7b94f67d0, (null)=0x0000000000000000) at Logging_Strategy.cpp:432:48 frame DOCGroup#9: 0x0000000107af7ac2 NetSequencer`ACE_Event_Handler_Handle_Timeout_Upcall::timeout(this=0x00006000022c8020, timer_queue=0x00007f80f32041c0, event_handler=0x00006000012f01b0, act=0x0000000000000000, recurring_timer=1, cur_time=0x00007ff7b94f67d0) at Event_Handler_Handle_Timeout_Upcall.cpp:42:22 frame DOCGroup#10: 0x0000000107b38598 NetSequencer`ACE_Timer_Queue_T<ACE_Event_Handler*, ACE_Event_Handler_Handle_Timeout_Upcall, ACE_Recursive_Thread_Mutex, ACE_FPointer_Time_Policy>::upcall(this=0x00007f80f32041c0, info=0x00007ff7b94f6720, cur_time=0x00007ff7b94f67d0) at Timer_Queue_T.inl:36:27 frame DOCGroup#11: 0x0000000107b35702 NetSequencer`ACE_Timer_Queue_T<ACE_Event_Handler*, ACE_Event_Handler_Handle_Timeout_Upcall, ACE_Recursive_Thread_Mutex, ACE_FPointer_Time_Policy>::expire(this=0x00007f80f32041c0, cur_time=0x00007ff7b94f67d0) at Timer_Queue_T.cpp:289:13 frame DOCGroup#12: 0x0000000107b3581f NetSequencer`ACE_Timer_Queue_T<ACE_Event_Handler*, ACE_Event_Handler_Handle_Timeout_Upcall, ACE_Recursive_Thread_Mutex, ACE_FPointer_Time_Policy>::expire(this=0x00007f80f32041c0) at Timer_Queue_T.cpp:258:16 frame DOCGroup#13: 0x0000000107b33a41 NetSequencer`ACE_Select_Reactor_T<ACE_Reactor_Token_T<ACE_Token> >::dispatch_timer_handlers(this=0x00007f80e2808e00, number_of_handlers_dispatched=0x00007ff7b94f6838) at Select_Reactor_T.cpp:1153:56 frame DOCGroup#14: 0x0000000107b33932 NetSequencer`ACE_Select_Reactor_T<ACE_Reactor_Token_T<ACE_Token> >::dispatch(this=0x00007f80e2808e00, active_handle_count=0, dispatch_set=0x00007f80e2808e38) at Select_Reactor_T.cpp:1348:22 frame DOCGroup#15: 0x0000000107b3acb2 NetSequencer`ACE_Select_Reactor_T<ACE_Reactor_Token_T<ACE_Token> >::handle_events_i(this=0x00007f80e2808e00, max_wait_time=0x0000000000000000) at Select_Reactor_T.cpp:1463:15 frame DOCGroup#16: 0x0000000107b306de NetSequencer`ACE_Select_Reactor_T<ACE_Reactor_Token_T<ACE_Token> >::handle_events(this=0x00007f80e2808e00, max_wait_time=0x0000000000000000) at Select_Reactor_T.cpp:1439:16 frame DOCGroup#17: 0x0000000107b2e859 NetSequencer`ACE_Reactor::run_reactor_event_loop(this=0x00006000020f4540, eh=0x0000000000000000)(ACE_Reactor*)) at Reactor.cpp:218:49 frame DOCGroup#18: 0x0000000106ab72c5 NetSequencer`SeqNetServer::go(this=0x00007f80f312da48) at Server.cpp:215:49 ... ``` Another thread that is stuck on `fwrite()` when attempting to log during log rotation: ``` thread DOCGroup#7, name = 'TestMaster' frame #0: 0x00007ff8187fdbd2 libsystem_kernel.dylib`__psynch_mutexwait + 10 frame DOCGroup#1: 0x00007ff818835e7e libsystem_pthread.dylib`_pthread_mutex_firstfit_lock_wait + 76 frame DOCGroup#2: 0x00007ff818833cbb libsystem_pthread.dylib`_pthread_mutex_firstfit_lock_slow + 205 frame DOCGroup#3: 0x00007ff818714ae8 libsystem_c.dylib`flockfile + 31 frame DOCGroup#4: 0x00007ff818729cc6 libsystem_c.dylib`fwrite + 66 frame DOCGroup#5: 0x0000000106a3dabe NetSequencer`std::__1::basic_filebuf<char, std::__1::char_traits<char> >::overflow(this=0x00007f80f3204328, __c=49) at fstream:823:17 frame DOCGroup#6: 0x00007ff8187a27c1 libc++.1.dylib`std::__1::basic_streambuf<char, std::__1::char_traits<char> >::xsputn(char const*, long) + 109 frame DOCGroup#7: 0x0000000106a3f9a6 NetSequencer`std::__1::basic_streambuf<char, std::__1::char_traits<char> >::sputn(this=0x00007f80f3204328, __s="NTC (58424|123145504292864|2022-11-16 05:41:53.094817 HopTracerouteData::getRtts) testId=_42147-1GHN9QEGN_76601, ttl=10, pkt 3403, sendSize=92, recvSize=0, rtt=0, send=1668606099528987, recv=0\n", __n=193) at streambuf:229:14 frame DOCGroup#8: 0x0000000106a3f821 NetSequencer`std::__1::ostreambuf_iterator<char, std::__1::char_traits<char> > std::__1::__pad_and_output<char, std::__1::char_traits<char> >(__s=ostreambuf_iterator<char, std::__1::char_traits<char> > @ 0x000070000c09c190, __ob="NTC (58424|123145504292864|2022-11-16 05:41:53.094817 HopTracerouteData::getRtts) testId=_42147-1GHN9QEGN_76601, ttl=10, pkt 3403, sendSize=92, recvSize=0, rtt=0, send=1668606099528987, recv=0\n", __op="NTC (58424|123145504292864|2022-11-16 05:41:53.094817 HopTracerouteData::getRtts) testId=_42147-1GHN9QEGN_76601, ttl=10, pkt 3403, sendSize=92, recvSize=0, rtt=0, send=1668606099528987, recv=0\n", __oe="", __iob=0x00007f80f3204320, __fl=32 ' ') at locale:1428:26 frame DOCGroup#9: 0x0000000106a3f4fa NetSequencer`std::__1::basic_ostream<char, std::__1::char_traits<char> >& std::__1::__put_character_sequence<char, std::__1::char_traits<char> >(__os=0x00007f80f3204320, __str="NTC (58424|123145504292864|2022-11-16 05:41:53.094817 HopTracerouteData::getRtts) testId=_42147-1GHN9QEGN_76601, ttl=10, pkt 3403, sendSize=92, recvSize=0, rtt=0, send=1668606099528987, recv=0\n", __len=193) at ostream:718:17 frame DOCGroup#10: 0x0000000106abfaf9 NetSequencer`std::__1::basic_ostream<char, std::__1::char_traits<char> >& std::__1::operator<<<std::__1::char_traits<char> >(__os=0x00007f80f3204320, __str="NTC (58424|123145504292864|2022-11-16 05:41:53.094817 HopTracerouteData::getRtts) testId=_42147-1GHN9QEGN_76601, ttl=10, pkt 3403, sendSize=92, recvSize=0, rtt=0, send=1668606099528987, recv=0\n") at ostream:857:12 frame DOCGroup#11: 0x0000000107b0eb7a NetSequencer`ACE_Log_Record::print(this=0x000070000c09cf20, host_name=0x0000000000000000, verbose_flag=5, s=0x00007f80f3204320) at Log_Record.cpp:427:13 frame DOCGroup#12: 0x0000000107b0b81d NetSequencer`ACE_Log_Msg::log(this=0x00007f810400c000, log_record=0x000070000c09cf20, suppress_stderr=0) at Log_Msg.cpp:2932:20 frame DOCGroup#13: 0x0000000107b0aed9 NetSequencer`ACE_Log_Msg::log(this=0x00007f810400c000, format_str="", log_priority=LM_NOTICE, argp=0x000070000c09e1b0, category=0x0000000000000000) at Log_Msg.cpp:2200:22 frame DOCGroup#14: 0x000000010750e196 NetSequencer`APN::LogUtil::log(logPriority=LM_NOTICE, formatStr="NTC%I (%P|%t|%D HopTracerouteData::getRtts) testId=%s, ttl=%u, pkt %u, sendSize=%u, recvSize=%u, rtt=%u, send=%Q, recv=%Q\n") at macros.cpp:44:19 ... ```

ACE_Process on Windows:

35cce6f

Allow redirection of child's stdout/stderr when there is no stdin handle available (for example when running in a service). TAO_IDL drv_preproc: check for errors from ACE_Process

mitza-oci self-assigned this Feb 10, 2015

mitza-oci added the bug label Feb 10, 2015

jwillemsen reviewed Feb 11, 2015
View reviewed changes

jwillemsen added this to the ATCD x.3.2 milestone Feb 11, 2015

mitza-oci added 2 commits February 11, 2015 08:58

Updated error logging format string to match other instances in this …

ced85d0

…file.

Updated the remaining cases of %s logging formatters for prog_name() …

4eb6e57

…to %C.

mitza-oci added a commit that referenced this pull request Feb 11, 2015

Merge pull request #6 from mitza-oci/master

b82b798

ACE_Process std file handles on Windows

mitza-oci merged commit b82b798 into DOCGroup:master Feb 11, 2015

qdztxc mentioned this pull request Dec 7, 2018

ACE doesn't support openssl 1.1.1 #772

Closed

Prjpshriya mentioned this pull request Feb 5, 2021

Core dump at shutdown after upgrade of ACE from 6.0.1 to 6.5.12 on linux #1428

Open

pierrebizz mentioned this pull request Feb 2, 2023

Segfault using TAO SSL connection with dev poll reactor #2045

Open

Sivasundareswaran mentioned this pull request May 22, 2023

ACE Logger Crash #2072

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ACE_Process std file handles on Windows#6

ACE_Process std file handles on Windows#6
mitza-oci merged 3 commits intoDOCGroup:masterfrom
mitza-oci:master

mitza-oci commented Feb 10, 2015

Uh oh!

jwillemsen Feb 11, 2015

Uh oh!

mitza-oci Feb 11, 2015

Uh oh!

jwillemsen Feb 11, 2015

Uh oh!

mitza-oci Feb 11, 2015

Uh oh!

jwillemsen commented Feb 11, 2015

Uh oh!

mitza-oci commented Feb 11, 2015

Uh oh!

jwillemsen commented Feb 11, 2015

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

mitza-oci commented Feb 10, 2015

Uh oh!

jwillemsen Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

mitza-oci Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

jwillemsen Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

mitza-oci Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

jwillemsen commented Feb 11, 2015

Uh oh!

mitza-oci commented Feb 11, 2015

Uh oh!

jwillemsen commented Feb 11, 2015

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants