Merged
Conversation
- Removed precip, tmax, tmin. These were never official CBH variable names. - Changed version for hru_ppt, tmax_hru and tmin_hru to 5.0.0. - Added version to all CBH variables.
- enforce official CBH variable names for ASCII format when control object is supplied. - fix _FillValue error when writing to netCDF format and metadata is missing. - rename var_src property to cbh_src. - _cbh_to_xarray() now expects a dictionary of filepaths and variable names instead of a list of file paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functionality to improve handling of legacy naming of CBH variable names. The variables are now standardized according to currently PRMS 5.2.1.1 CBH variable naming.
ASCII CBH files will have their variable renamed if needed and if possible to the current standards. If the new variable names can be used then additional metadata becomes available to view and/or write to netCDF attributes.
NetCDF CBH files are read as-is. If writing to a netCDF file the existing variables/attributes will be written. If writing to an ASCII file the variable will be renamed if possible to the current standard name.