We want join, not implode

Author: nickygerritsen

webapp/src/Controller/Jury/ProblemController.php

@@ -570,7 +570,7 @@ public function testcasesAction(Request $request, int $probId): Response
         if ($request->isMethod('POST')) {
             if (!empty($lockedContests)) {
                 $this->addFlash('danger', 'Cannot edit problem / testcases, it belongs to locked contest(s) '
-                    . implode(', ', $lockedContests));
+                    . join(', ', $lockedContests));
                 return $this->redirectToRoute('jury_problem', ['probId' => $problem->getProbid()]);
             }
             $messages      = [];
@@ -788,7 +788,7 @@ public function testcasesAction(Request $request, int $probId): Response
         if (!empty($lockedContests)) {
             $this->addFlash('warning',
                 'Problem belongs to locked contest ('
-                . implode($lockedContests)
+                . join($lockedContests)
                 . ', disallowing editing.');
         }
         $data = [

webapp/src/Entity/ImmutableExecutable.php

@@ -76,7 +76,7 @@ protected function updateHash(): void
         $filesArray = $this->files->toArray();
         uasort($filesArray, fn(ExecutableFile $a, ExecutableFile $b) => strcmp($a->getFilename(), $b->getFilename()));
         $this->hash = md5(
-            implode(
+            join(
                 array_map(
                     fn(ExecutableFile $file) => $file->getHash() . $file->getFilename() . $file->isExecutable(),
                     $filesArray

webapp/src/Service/ImportProblemService.php

@@ -468,7 +468,7 @@ public function importZippedProblem(
             }
             if ($numCases > 0) {
                 $messages['info'][] = sprintf("Added/updated %d %s testcase(s): {%s}.{in,ans}",
-                    $numCases, $type, implode(',', $testcaseNames));
+                    $numCases, $type, join(',', $testcaseNames));
             }
         }
 
@@ -484,7 +484,7 @@ public function importZippedProblem(
 
         if (!empty($removedTestcases)) {
             $messages['info'][] = sprintf("Removed %d testcase(s): {%s}.{in,ans}",
-                count($removedTestcases), implode(',', $removedTestcases));
+                count($removedTestcases), join(',', $removedTestcases));
         }
 
         // Load the current attachments to see if we need to delete, update or insert attachments
@@ -593,7 +593,7 @@ public function importZippedProblem(
 
         if (!empty($removedAttachments)) {
             $messages['info'][] = sprintf("Removed %d attachments(s): {%s}",
-                count($removedAttachments), implode(',', $removedAttachments));
+                count($removedAttachments), join(',', $removedAttachments));
         }
 
         $this->em->wrapInTransaction(function () use ($testcases, $startRank): void {
@@ -796,15 +796,15 @@ public function importZippedProblem(
 
             if ($numJurySolutions > 0) {
                 $messages['info'][] = sprintf('Added %d jury solution(s): %s', $numJurySolutions,
-                    implode(', ', $successful_subs));
+                    join(', ', $successful_subs));
             }
             if (!empty($subs_with_unknown_lang)) {
                 $messages['warning'][] = sprintf("Could not add jury solution(s) due to unknown language: %s",
-                    implode(', ', $subs_with_unknown_lang));
+                    join(', ', $subs_with_unknown_lang));
             }
             if (!empty($too_large_subs)) {
                 $messages['warning'][] = sprintf("Could not add jury solution(s) because they are too large: %s",
-                    implode(', ', $too_large_subs));
+                    join(', ', $too_large_subs));
             }
         } else {
             $messages['warning'][] = 'No jury solutions added: problem not submittable.';

webapp/src/Twig/TwigExtension.php

@@ -431,7 +431,7 @@ public function displayTestcaseResults(array $testcases, bool $submissionDone, b
             }
             $icon    = sprintf('<span class="badge text-bg-%s badge-testcase">%s</span>', $class, $text);
             $results .= sprintf('<a title="%s" href="#run-%d" %s>%s</a>',
-                                implode(', ', $titleElements), $testcase->getRank(),
+                join(', ', $titleElements), $testcase->getRank(),
                                 $isCorrect ? 'onclick="display_correctruns(true);"' : '', $icon);
         }