Test database upgrades

[vmcj]

Currently the database upgrade is not tested:

• Install an older (un)supported release via the documentation
• Do some minimal actions:
  • Create a team
  • Create a clarification
  • Answer it
  • Upload a problem
  • Submit a problem
  • Create some extra entities and delete those for example:
    • Create a contest,
    • With a team submit
    • Delete the contest again

Keep the dump small, upgrade tests can be fast as we don't need a lot of problems/submissions but rather more (rarely used) functions/features tested.

When we have this dump we can make an CI job to test the upgrade with ./bin/dj_setup_database upgrade.

[as6325400]

So should I run some operations locally, export the database, and then run dj_setup_database upgrade in CI to check for errors? Where should I store the exported .sql file?

Or should everything be done in CI, including the old version of Domjudge?

[vmcj]

So should I run some operations locally, export the database, and then run dj_setup_database upgrade in CI to check for errors? Where should I store the exported .sql file?

I would put the old database in .github/jobs/data and indeed run dj_setup_database in the CI.

Or should everything be done in CI, including the old version of Domjudge?

That would only slow it down as that part should always lead to the same conclusion.

[as6325400]

So, where should the old database file be placed?

.github/jobs ?