Replace Ace with Monaco editor #2838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
force-pushed
the
monaco-editor
branch
from
afee8f2 to
3d5f4ef
Compare
meisterT
reviewed
Nov 23, 2024
nickygerritsen
force-pushed
the
monaco-editor
branch
from
3d5f4ef to
cabdbfe
Compare
meisterT
reviewed
Nov 23, 2024
webapp/templates/jury/base.html.twig
Outdated
| @@ -21,6 +21,12 @@ | |||
| {% include 'jury/menu.html.twig' %} | |||
| {% endblock %} | |||
| {% block footer %} | |||
| <script src="{{ asset('js/monaco/vs/loader.js') }}"></script> | |||
| <script> | |||
| {# A bit ugly to do the replace, but Symfony adds a version to #} | |||
nickygerritsen
force-pushed
the
monaco-editor
branch
from
cabdbfe to
300e3c1
Compare
meisterT
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2689.
Beautiful screenshots:
