Skip to content

feat: track player relationships from NPC conversations#106

Merged
JOY (JOY) merged 1 commit into
devfrom
codex/conversation-recall
May 20, 2026
Merged

feat: track player relationships from NPC conversations#106
JOY (JOY) merged 1 commit into
devfrom
codex/conversation-recall

Conversation

@JOY
Copy link
Copy Markdown
Contributor

Summary

  • update closed NPC conversation side effects to add a lightweight player relationship ledger entry
  • preserve idempotency by tying relationship writes to the closed conversation memory summary path
  • cover the player relationship record in the Nakama runtime test

Local review

  • Local code-review fallback: APPROVED
  • ADR compliance: compliant with Nakama backend authority and server-side intent validation
  • Security: no Unity client key path added, no LLM authority expansion, no direct model state mutation

Tests

  • npm run build
  • npm test
  • git diff --check
  • em-dash scan on changed diff

@JOY
Copy link
Copy Markdown
Contributor Author

Codex (@codex) review

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@JOY JOY (JOY) merged commit 65d84d6 into dev May 20, 2026
1 check passed
@JOY JOY (JOY) deleted the codex/conversation-recall branch May 20, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant