Skip to content

feat: wire Ida Faber roster smoke#229

Merged
JOY (JOY) merged 1 commit into
devfrom
codex/gameplay-followup-ui-combat
May 24, 2026
Merged

feat: wire Ida Faber roster smoke#229
JOY (JOY) merged 1 commit into
devfrom
codex/gameplay-followup-ui-combat

Conversation

@JOY
Copy link
Copy Markdown
Contributor

Summary

  • Wire the 3 imported Ida Faber body variants into the prototype roster by generating project-owned wrapper prefabs/materials under Assets/_SecondSpawn.
  • Expand the hub prototype spawner from 10 to 13 permanent NPC markers so the new bodies appear in Play Mode.
  • Fix the Nakama runtime registration path by registering top-level RPC functions directly, while preserving explicit secret checks on protected mutation/setup RPCs.
  • Document the Unity best-practice audit triage, UI Toolkit/uGUI decision boundary, platform targeting notes, and the client-safe society tick prototype boundary.

Verification

  • npm.cmd run build in backend/nakama: pass
  • npm.cmd test in backend/nakama: pass after build/test were run sequentially
  • npx.cmd markdownlint-cli2 ...: pass for changed docs
  • git diff --check origin/dev...HEAD: pass
  • em-dash scan on changed docs: pass
  • Unity MCP Play Mode smoke: active scene ZoneTest_Hub, _PermanentNpcMarkers spawned with 13 children, Nakama container healthy, Unity console 0 errors after stop/clear; observed one known Visual Studio UDP warning and transient Unity beta GC-handle asserts during Play Mode stop with no stacktrace

Local review fallback

  • Checked Nakama boundary changes against project hard rules: Unity still calls Nakama only, no provider keys in client, secondspawn_npc_seed, actor memory consolidation, and relationship update remain protected by explicit server-side secret checks.
  • secondspawn_npc_society_tick is intentionally client-callable for the current Play Mode prototype and returns scheduling candidates only; authoritative mutation still goes through validated intent/storage paths.

Notes

@JOY JOY (JOY) merged commit 6e22776 into dev May 24, 2026
2 checks passed
@JOY JOY (JOY) deleted the codex/gameplay-followup-ui-combat branch May 24, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant