feat: wire Ida Faber roster smoke#229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assets/_SecondSpawn.Verification
npm.cmd run buildinbackend/nakama: passnpm.cmd testinbackend/nakama: pass after build/test were run sequentiallynpx.cmd markdownlint-cli2 ...: pass for changed docsgit diff --check origin/dev...HEAD: passZoneTest_Hub,_PermanentNpcMarkersspawned with 13 children, Nakama container healthy, Unity console 0 errors after stop/clear; observed one known Visual Studio UDP warning and transient Unity beta GC-handle asserts during Play Mode stop with no stacktraceLocal review fallback
secondspawn_npc_seed, actor memory consolidation, and relationship update remain protected by explicit server-side secret checks.secondspawn_npc_society_tickis intentionally client-callable for the current Play Mode prototype and returns scheduling candidates only; authoritative mutation still goes through validated intent/storage paths.Notes
dev; PR docs: organize public GitBook navigation #222 was already merged. Draft PRs test: cover NPC state of mind surfaces #205 and fix: polish prototype combat and chat presentation #191 were left untouched because they are still draft / pending Unity validation.