Skip to content

feat(controller): add Simple KCC controller base#3

Merged
JOY (JOY) merged 2 commits into
devfrom
codex/simple-kcc-controller-spike
May 16, 2026
Merged

feat(controller): add Simple KCC controller base#3
JOY (JOY) merged 2 commits into
devfrom
codex/simple-kcc-controller-spike

Conversation

@JOY
Copy link
Copy Markdown
Contributor

Summary

  • import Fusion Simple KCC addon into Unity project
  • wire NetworkPlayer and player prefab to Simple KCC
  • document paid asset boundaries and Pirate Adventure reference review
  • update controller prototype and setup docs

Verification

  • secret scan passed for known Supabase/Nakama credentials
  • paid RPG animation asset folder remains ignored
  • git diff --cached --check passed before commit
  • Docker/Nakama work is in separate PR feat(backend): add Nakama OSS local base #2

Notes

Unity compile still needs final editor verification after package resolution. Draft PR because project rules require reviewer pass before merge.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Photon Fusion Simple KCC addon to establish a server-authoritative movement baseline, updating NetworkPlayer.cs and the player prefab accordingly. The project roadmap and documentation have been expanded to include a Simple KCC spike phase and guidelines for managing paid assets. Feedback identifies opportunities to clean up the NetworkPlayer script by removing redundant component references and suggests removing a hardcoded local file path from the documentation to maintain environment privacy.


public override void Spawned()
{
_kcc ??= GetComponent<SimpleKCC>();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This initialization is redundant because _kcc is already assigned in Awake(). Since SimpleKCC is a required component on this GameObject, the reference is guaranteed to be available.

Comment on lines +56 to +59
if (_kcc == null)
{
return;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This null check is unnecessary given the [RequireComponent(typeof(SimpleKCC))] attribute and the initialization in Awake(). Removing it helps keep the FixedUpdateNetwork method concise.

*Status: Draft*
*Created: 2026-05-14*
*Author: Codex*
*Local Source Reviewed: `C:\Users\JOY\Downloads\fusion-pirate-adventure-2.0.12.zip`*
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid including hardcoded local file paths in public documentation. It is better to use a generic description of the source material to maintain professional standards and avoid leaking local environment details.

Suggested change
*Local Source Reviewed: `C:\Users\JOY\Downloads\fusion-pirate-adventure-2.0.12.zip`*
*Local Source Reviewed: Photon Fusion Pirate Adventure 2.0.12 sample package*

@JOY JOY (JOY) merged commit d0e1062 into dev May 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant