Skip to content

add drivers: igc, e1000e & r8169#618

Closed
appliedprivacy wants to merge 1 commit into
DPDK:mainfrom
appliedprivacy:patch-1
Closed

add drivers: igc, e1000e & r8169#618
appliedprivacy wants to merge 1 commit into
DPDK:mainfrom
appliedprivacy:patch-1

Conversation

@appliedprivacy
Copy link
Copy Markdown

@appliedprivacy appliedprivacy commented May 18, 2026

related to:
https://mails.dpdk.org/archives/grout/2026-May/000041.html

Overview

Adds support for three new Intel and Realtek Ethernet network drivers (igc, e1000e, r8169) to the grout build system.

Changes

meson.build: Updated the libdpdk dependency configuration to include three additional network drivers in the enable_drivers option:

  • net/igc (Intel Gigabit Ethernet Controller)
  • net/e1000e (Intel 82574L Gigabit Ethernet)
  • net/r8169 (Realtek 8169 Gigabit Ethernet)

These drivers are now compiled as part of the DPDK library used by grout, enabling support for these physical network interfaces at the datapath layer.

Review Change Stack

Signed-off-by: appliedprivacy <33653399+appliedprivacy@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: db3ec938-d190-4e96-9e7a-0583f332116f

📥 Commits

Reviewing files that changed from the base of the PR and between 0ab251b and 553497e.

📒 Files selected for processing (1)
  • meson.build

📝 Walkthrough

Walkthrough

The PR updates the meson build configuration for the libdpdk dependency, specifically modifying the enable_drivers list on line 75 of meson.build. The change adds three additional network drivers—net/igc, net/e1000e, and net/r8169—to the driver set and reorders the existing driver entries. This expands the network driver support available during DPDK build compilation with the specified fallback configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@rjarry rjarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the quick PR ;)

Could you rewrite your commit message to make the linter happy? Something like:

dpdk: enable additional intel and realtek drivers

Add support for Intel I226-V and Realtek RTL8125 NICs.

Link: https://mails.dpdk.org/archives/grout/2026-May/000041.html
Signed-off-by: Your Real Name <email@tld.foo>

👍

@appliedprivacy
Copy link
Copy Markdown
Author

I don't actually know how to change a commit message in the github webinterface.
It is probably less effort for you to change the single line directly instead of guiding us through. Sorry, didn't mean to cause unnecessary work with this PR.

@rjarry
Copy link
Copy Markdown
Collaborator

rjarry commented May 18, 2026

No worries. I didn't realize you had sent this over the web interface. I'll send another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants