Skip to content

added hardmod guide into the index#1

Merged
Epicpkmn11 merged 17 commits intoDS-Homebrew:mainfrom
YourKalamity:main
Jan 17, 2021
Merged

added hardmod guide into the index#1
Epicpkmn11 merged 17 commits intoDS-Homebrew:mainfrom
YourKalamity:main

Conversation

@YourKalamity
Copy link
Contributor

unsure if it's too long though

Copy link
Member

@NightScript370 NightScript370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first PR. Let's try and get this few issues first though

@YourKalamity YourKalamity marked this pull request as draft December 24, 2020 13:49
@YourKalamity YourKalamity marked this pull request as ready for review December 24, 2020 14:01
Copy link
Member

@Epicpkmn11 Epicpkmn11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are wrong ;P

Copy link
Member

@Epicpkmn11 Epicpkmn11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for making so many different reviews ;P
This one's just a bunch of minor typo fixes and other little formatting changes

YourKalamity and others added 3 commits December 25, 2020 11:54
Co-authored-by: Pk11 <epicpkmn11@outlook.com>
Co-authored-by: Pk11 <epicpkmn11@outlook.com>
Co-authored-by: Pk11 <epicpkmn11@outlook.com>
@Epicpkmn11
Copy link
Member

@NightYoshi370 This look good to you now? I think it looks fine to me

@Peter0x44
Copy link
Contributor

it's missing a note to make sure you remove the nocash footer before flashing

Copy link
Member

@NightScript370 NightScript370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to get urmum's comment fixed first.

@Peter0x44
Copy link
Contributor

I'm not sure it actually matters but is far better to put a needless step than have something that could potentially screw you badly

@YourKalamity
Copy link
Contributor Author

@Epicpkmn11 @NightYoshi370 this fine now?

Co-authored-by: Pk11 <epicpkmn11@outlook.com>
@YourKalamity
Copy link
Contributor Author

didn't even know the nand mode existed - seems like it doesnt ask for an output folder in nand mode

Co-authored-by: Pk11 <epicpkmn11@outlook.com>
@Epicpkmn11 Epicpkmn11 merged commit 04b359a into DS-Homebrew:main Jan 17, 2021
Kaisaan pushed a commit that referenced this pull request Feb 27, 2021
Add instructions on how to install javafx on Arch.
NightScript370 added a commit that referenced this pull request Nov 7, 2022
Tense change, no single bullet, remove accidentally forgotten line

Co-authored-by: Pk11 <epicpkmn11@outlook.com>
lifehackerhansol pushed a commit that referenced this pull request Apr 28, 2023
Tense change, no single bullet, remove accidentally forgotten line

Co-authored-by: Pk11 <epicpkmn11@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants