Components: Added container component for object fields & updated code.json schema#10
Merged
natalialuzuriaga merged 5 commits intomainfrom Jan 8, 2025
Merged
Components: Added container component for object fields & updated code.json schema#10natalialuzuriaga merged 5 commits intomainfrom
natalialuzuriaga merged 5 commits intomainfrom
Conversation
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
natalialuzuriaga
changed the title
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
natalialuzuriaga
requested review from
DinneK,
IsaacMilarky,
decause-gov and
sachin-panayil
natalialuzuriaga
commented
Jan 7, 2025
| "enum": [ | ||
| "github.com/CMSgov", | ||
| "github.com/CMSgov", | ||
| "github.com/CMS-Enterprise", |
Contributor
Author
There was a problem hiding this comment.
Cookiecutter options are: "repository_host": ["Github.com", "GitHub ENT", "GitHub Cloud", "GitLab.com", "GitLab ENT", "GitLab ENT CCSQ"]
Need to realign, do we want links or name of github?
Contributor
There was a problem hiding this comment.
I think links are most useful, then people can check themselves, but I'm willing to change my mind.
decause-gov
approved these changes
Jan 7, 2025
Contributor
decause-gov
left a comment
decause-gov
left a comment
There was a problem hiding this comment.
Excited to see how this looks! 🚢
| return components; | ||
| } | ||
|
|
||
| // Iterates through each json field and creates component array for Form.io |
| "repositoryURL": { | ||
| "type": "string", | ||
| "format": "uri", | ||
| "description": "The URL of the public release repository for open source repositories. This field is not required for repositories that are only available as government-wide reuse or are closed (pursuant to one of the exemptions)." |
| "enum": [ | ||
| "github.com/CMSgov", | ||
| "github.com/CMSgov", | ||
| "github.com/CMS-Enterprise", |
Contributor
There was a problem hiding this comment.
I think links are most useful, then people can check themselves, but I'm willing to change my mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
To collect information for object fields like
dateandcontact, this requires multiple components, thus we need to structure the form inputs accordingly.Solution
This PR implements container components. This allows us to group inputs needed for the object fields. Used some recursion magic to be able to easily extract each field of the object and create a component for it.
Alongside, added
repositoryURLto schema, updated options ofrepositoryHostand added missing description fields to some fields. File cleanup tooResult
Users can generate forms using json schemas that have fields with
type: objectWhen users fill out the form and click submit, the
code.jsonis generated and downloaded onto their machine.Test Plan
python3 -m http.server 8000form.htmlcode.json. File contents should match what was submitted in the form!