Components: Implemented single select and text input components#3
Merged
natalialuzuriaga merged 4 commits intomainfrom Dec 13, 2024
Merged
Components: Implemented single select and text input components#3natalialuzuriaga merged 4 commits intomainfrom
natalialuzuriaga merged 4 commits intomainfrom
Conversation
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
| switch (fieldObject["type"]) { | ||
| case "string": | ||
| var componentType = determineType(fieldObject); | ||
| switch (componentType) { |
Collaborator
There was a problem hiding this comment.
love the use of a switch here 👍
sachin-panayil
approved these changes
Dec 12, 2024
Collaborator
sachin-panayil
left a comment
There was a problem hiding this comment.
tested and it looks and works great! one minor suggestion is that maybe there could be some visual differentiation when the textField is type: String and type: Number
Contributor
Author
For sure, noted! Will address when I start working on the form styling more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the form only supports text fields. For collect information for fields like
laborHours,vcs, andstatus, we need to implement more components.Solution
This PR implements all single select and text input components. Now the form can create the following components:
Result
Users can generate forms using json schemas that have fields with
type: string, 'type: number' and 'enum'.When users fill out the form and click submit, the
code.jsonis generated and downloaded onto their machine.Test Plan
python3 -m http.server 8000form.htmlcode.json. File contents should match what was submitted in the form!Will create unit tests in a separate PR after OSAB