Remove PyGithub and Add Support for Gitlab and Bitbucket #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…gitlab orgs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
IsaacMilarky
requested review from
DinneK,
decause-gov,
natalialuzuriaga and
sachin-panayil
Collaborator
sachin-panayil
left a comment
sachin-panayil
left a comment
There was a problem hiding this comment.
this is great work! makes this way more modular and robust. i have a few comments / notes about stuff but overall, great work! 🔥
IDEA: we should implement pagination of API requests soon so it doesn't come back to bite us
| for org in args.orgs.split(","): | ||
| org = org.strip() | ||
| indexGen.process_organization(org) | ||
| indexGen.process_github_org_files(org) |
Collaborator
There was a problem hiding this comment.
it seems like that when running the script, we call and check for Github orgs only but we should call to check all forges
Contributor
Author
There was a problem hiding this comment.
Yeah we should update the script for that later in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PyGithub and Add Support for Gitlab and Bitbucket
Problem
PyGithub has less control over rate limiting than I would like it too for our purposes. We also did not previously have support for platforms other than GitHub
Solution
Remove PyGithub. Add functionality to fetch code.json files from GitLab and Bitbucket.
Testing
Ran
main.pylocally