Add Missing Test for PractitionerRoleViewSetTestCase #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Co-authored-by: Adam Bachman <adam.bachman@cms.hhs.gov>
abachman-dsac
approved these changes
Nov 3, 2025
Member
abachman-dsac
left a comment
abachman-dsac
left a comment
There was a problem hiding this comment.
I am comfortable approving this test, but I would prefer that future work begin introducing per-test-case data loading.
Test expectations which are only true when a dataset contained in a different sub-project has been loaded are more brittle than we should accept, long-term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Missing Test for PractitionerRoleViewSetTestCase
Jira Ticket #NDH-250
Problem
We are missing a test that tests the sorting of the list of Practioners by their corresponding locations
Solution
Create a test by checking the ids returned by the endpoint and verifying that they are in the order of their location names.
Test Plan
Run
make test