Update release branch - take 02 #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
…210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
- because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy
…rect Remove strategy page redirect from directory.cms.gov
* create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
* add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
* ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes
* [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition
* added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
* refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes
* For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
…173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
* update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax
* introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
- creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
* [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml
* NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com>
* [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test
* add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
- generic API support updates - end-to-end test
* used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes
* exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
* contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor
* some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * adding parent_org and associated test * fixing broken tests * linting fixes * fixing accidental package-lock stuff
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
* Change trigger for backend tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove upstream reporting tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
IsaacMilarky
previously approved these changes
Dec 11, 2025
* adding public, npd as the search path * whops, wrong place * deleted the thing
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
Co-authored-by: Blaine Price <william.price@cms.hhs.gov>
- add optional "make watch-frontend-test-assets" target for live playwright testing - debug Practitioner end-to-end test in CI - update playwright documentation
spopelka-dsac
approved these changes
Dec 12, 2025
IsaacMilarky
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production release cut.
Includes: