Conversation
added 2 commits
June 10, 2021 16:39
mortalYoung
reviewed
Jun 11, 2021
wewoor
reviewed
Jun 16, 2021
wewoor
reviewed
Jun 17, 2021
Closed
wewoor
reviewed
Jun 18, 2021
| constructor() { | ||
| super(); | ||
| this.state = container.resolve(LayoutModel); | ||
| this._container = document.getElementById(ID_APP) || document.body; |
Collaborator
There was a problem hiding this comment.
layoutService container 的初始化,必须要再 MoleculeProvide DidMount 中去执行,ID_APP 目前是指Workbench View, 这个会存在实例化 layoutService 的时候,container 始终是 body 元素的问题
mortalYoung
referenced
this pull request
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #173