Skip to content

Design and Extract LayoutService#176

Merged
wewoor merged 14 commits intomainfrom
refactor_layout
Jun 21, 2021
Merged

Design and Extract LayoutService#176
wewoor merged 14 commits intomainfrom
refactor_layout

Conversation

@mumiao
Copy link
Copy Markdown
Collaborator

@mumiao mumiao commented Jun 10, 2021

Resolved #173

export interface ILayoutService extends Component{    
    setMenuBarHidden(): void;
    setSideBarHidden(): void;
    setPanelHidden(): void; 
    setActivityBarHidden(): void; 
    setStatusBarHidden(): void;   
    setPaneSize(splitPanePos: string[]): void;  
    setHorizontalPaneSize(horizontalSplitPanePos: string[]): void; 
    togglePanelMaximized(): void;   
    isPanelMaximized(): boolean | undefined;
    getContainer(domId: string): HTMLElement 
    setSideBarPosition(position: Position): void;
    getSideBarPosition(): Position;
    conatiner: HTMLElement | null;
}

@mumiao mumiao changed the title Design and Extract LayoutService 【WIP】Design and Extract LayoutService Jun 10, 2021
@mumiao mumiao self-assigned this Jun 10, 2021
@mumiao mumiao added the feature label Jun 10, 2021
@mumiao mumiao added this to the 0.9.0-alpha.3 milestone Jun 10, 2021
Comment thread src/services/workbench/layoutService.ts Outdated
Comment thread src/services/workbench/layoutService.ts
Comment thread src/services/workbench/panelService.ts Outdated
Comment thread src/workbench/workbench.tsx
@mumiao mumiao changed the title 【WIP】Design and Extract LayoutService Design and Extract LayoutService Jun 16, 2021
@mumiao mumiao requested a review from wewoor June 16, 2021 03:56
@mumiao mumiao added enhancement New feature or request refactoring Refactor and removed feature labels Jun 16, 2021
Comment thread src/services/workbench/activityBarService.ts Outdated
Comment thread src/services/workbench/layoutService.ts Outdated
Comment thread src/monaco/monacoService.ts Outdated
Comment thread src/services/workbench/layoutService.ts
@wewoor wewoor mentioned this pull request Jun 17, 2021
Comment thread src/services/workbench/layoutService.ts Outdated
constructor() {
super();
this.state = container.resolve(LayoutModel);
this._container = document.getElementById(ID_APP) || document.body;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layoutService container 的初始化,必须要再 MoleculeProvide DidMount 中去执行,ID_APP 目前是指Workbench View, 这个会存在实例化 layoutService 的时候,container 始终是 body 元素的问题

@wewoor wewoor merged commit a15245f into main Jun 21, 2021
@wewoor wewoor deleted the refactor_layout branch June 21, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactoring Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Layoutservice

3 participants