Skip to content

fix(folderTree): improve add root folder & delete dialog#192

Merged
wewoor merged 4 commits intomainfrom
fix/folderTree
Jun 22, 2021
Merged

fix(folderTree): improve add root folder & delete dialog#192
wewoor merged 4 commits intomainfrom
fix/folderTree

Conversation

@mortalYoung
Copy link
Copy Markdown
Collaborator

@mortalYoung mortalYoung commented Jun 22, 2021

简介

  • 修复新增根目录的问题,同时修复新增文件夹和新增文件没有 id 的问题
  • 修复 folderTree 在某些情况下会无法点出右键菜单的 bug
  • 优化 explorerServicefolderTreeService 中的方法
  • 优化 删除节点弹窗的 UI

主要变更

  • 优化 Tree 组件右键点击的交互
  • createFileOrFolder 方法移到 folderTreeService 中,感觉更应该是 folderTree 的方法 而不是 explorer 的方法
  • 新增 onNewRootFolder 方法,支持 extensions 订阅
  • 优化 folderTree 的右键菜单,包括 open to the side delete
  • 支持通过点击按钮创建根目录,可以不用通过 testPane 来创建根目录
  • 修复关闭弹窗用的是 dispose 而不是 hidden 的问题

Related Issues

Closed #190

Comment thread src/components/tree/index.tsx Outdated
Comment thread src/components/tree/index.tsx Outdated
Comment thread src/workbench/sidebar/explore/folderTree.tsx Outdated
Comment thread src/workbench/sidebar/explore/folderTree.tsx Outdated
Comment thread src/services/workbench/explorer/folderTreeService.ts Outdated
@wewoor wewoor added this to the 0.9.0-alpha.3 milestone Jun 22, 2021
@wewoor wewoor added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 22, 2021
@wewoor wewoor merged commit c49e534 into main Jun 22, 2021
@wewoor wewoor deleted the fix/folderTree branch June 22, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug collection about explore fileTree

2 participants