Skip to content

fix: height is lost after adjusting the input text#347

Merged
wewoor merged 3 commits intomainfrom
fix/search
Aug 19, 2021
Merged

fix: height is lost after adjusting the input text#347
wewoor merged 3 commits intomainfrom
fix/search

Conversation

@ProfBramble
Copy link
Copy Markdown
Contributor

Description

  • Solve the problem of height collapse when entering the text area and clearing the data

@ProfBramble ProfBramble self-assigned this Aug 19, 2021
@ProfBramble ProfBramble added the bug Something isn't working label Aug 19, 2021
@ProfBramble ProfBramble linked an issue Aug 19, 2021 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2021

Codecov Report

Merging #347 (30810a0) into main (22597b4) will increase coverage by 2.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   52.95%   55.85%   +2.90%     
==========================================
  Files         173      173              
  Lines        4604     4617      +13     
  Branches     1016     1018       +2     
==========================================
+ Hits         2438     2579     +141     
+ Misses       2138     2012     -126     
+ Partials       28       26       -2     
Impacted Files Coverage Δ
src/common/dom.ts 66.10% <0.00%> (+3.38%) ⬆️
src/components/select/option.tsx 100.00% <0.00%> (+75.00%) ⬆️
src/components/select/select.tsx 100.00% <0.00%> (+87.69%) ⬆️
src/services/problemsService.ts 100.00% <0.00%> (+92.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22597b4...30810a0. Read the comment docs.

@wewoor wewoor changed the title style: height is lost after adjusting the input text fix: height is lost after adjusting the input text Aug 19, 2021
@wewoor wewoor requested a review from mortalYoung August 19, 2021 10:39
@mortalYoung
Copy link
Copy Markdown
Collaborator

ci 挂了 看一哈

@ProfBramble ProfBramble force-pushed the fix/search branch 2 times, most recently from 24f5d1f to c31f39d Compare August 19, 2021 11:46
@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Aug 19, 2021
Copy link
Copy Markdown
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit d4f5512 into main Aug 19, 2021
@wewoor wewoor deleted the fix/search branch August 19, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize the SearchPane styles

3 participants