Skip to content

feat: support render icon in tab title#447

Merged
wewoor merged 3 commits intomainfrom
feat/tab
Sep 24, 2021
Merged

feat: support render icon in tab title#447
wewoor merged 3 commits intomainfrom
feat/tab

Conversation

@mortalYoung
Copy link
Copy Markdown
Collaborator

@mortalYoung mortalYoung commented Sep 24, 2021

简介

  • tab 组件支持渲染 icon

Resolved #427

主要变更

  • 由于 editor 的数据中已经带了 icon,直接拿过来,在 tab 中渲染即可

@mortalYoung mortalYoung self-assigned this Sep 24, 2021
@mortalYoung mortalYoung added this to the 0.9.0-beta.1 milestone Sep 24, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2021

Codecov Report

Merging #447 (fef6e63) into main (9ac1962) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   80.78%   80.80%   +0.01%     
==========================================
  Files         177      177              
  Lines        4914     4919       +5     
  Branches     1066     1069       +3     
==========================================
+ Hits         3970     3975       +5     
  Misses        935      935              
  Partials        9        9              
Impacted Files Coverage Δ
src/components/tabs/index.tsx 100.00% <ø> (ø)
src/components/tabs/tab.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac1962...fef6e63. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit d67c2e0 into main Sep 24, 2021
@wewoor wewoor deleted the feat/tab branch September 24, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom the Tab label content and icon

2 participants